From: Mike Frysinger <vapier.adi@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
LKML <linux-kernel@vger.kernel.org>,
linuxppc-dev@ozlabs.org, Wim Van Sebroeck <wim@iguana.be>,
uclinux-dist-devel@blackfin.uclinux.org,
Russell King <rmk+kernel@arm.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
linux-omap@vger.kernel.org,
Florian Fainelli <florian@openwrt.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [RFC] [PATCH] watchdog_info separation and constify
Date: Tue, 19 Jan 2010 16:52:21 -0500 [thread overview]
Message-ID: <8bd0f97a1001191352n4968bebep2342912c571595fa@mail.gmail.com> (raw)
In-Reply-To: <1263937351.18117.69.camel@Joe-Laptop.home>
On Tue, Jan 19, 2010 at 16:42, Joe Perches wrote:
> On Tue, 2010-01-19 at 22:17 +0100, Wim Van Sebroeck wrote:
>> -static struct watchdog_info at32_wdt_info =3D {
>> +static const struct watchdog_info at32_wdt_info =3D {
>
> It'd be good to use a consistent structure name:
>
> static const struct watchdog_info ident =3D {
> =C2=A0 =C2=A0 =C2=A0 =C2=A0etc...
> }
i'd agree (obviously i'm partial to the "xxx_wdt_info" form), but i'd
worry about this after the watchdog implementations are finally
unified ... might be less code needing standardization at that point
-mike
next prev parent reply other threads:[~2010-01-19 21:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 21:17 [RFC] [PATCH] watchdog_info separation and constify Wim Van Sebroeck
2010-01-19 21:27 ` Alan Cox
2010-01-19 22:00 ` Wim Van Sebroeck
2010-01-19 21:42 ` Joe Perches
2010-01-19 21:52 ` Mike Frysinger [this message]
2010-01-19 22:16 ` Mark Brown
2010-01-19 22:36 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a1001191352n4968bebep2342912c571595fa@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=florian@openwrt.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).