From: Tirumala Marri <tmarri@apm.com>
To: Stefan Roese <sr@denx.de>, linuxppc-dev@lists.ozlabs.org
Cc: linux-raid@vger.kernel.org, dan.j.williams@intel.com,
linux-crypto@vger.kernel.org, tmarri@amcc.com
Subject: RE: [PATCH] Adding ADMA support for PPC460EX DMA engine.
Date: Fri, 23 Jul 2010 14:39:24 -0700 [thread overview]
Message-ID: <8c2fc4da25db867b7daa7c4f618230b0@mail.gmail.com> (raw)
In-Reply-To: <201007230815.14464.sr@denx.de>
>As you describe above, a lot of the code seems to be copied from
>drivers/dma/ppc4xx/adma.c/h. Wouldn't it make more sense to factor out
the
>common code instead of duplicating it?
Hi Stefan,
Thanks for the review. There are definitely some functions can be
moved to a common file.
Hi Dan,
Could you also please review and see if there are any changes needed, so
I can include some changes as
Well in the modified patch.
Regards,
Marri
prev parent reply other threads:[~2010-07-23 21:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-23 0:57 [PATCH] Adding ADMA support for PPC460EX DMA engine tmarri
2010-07-23 6:15 ` Stefan Roese
2010-07-23 19:21 ` Dan Williams
2010-07-23 21:39 ` Tirumala Marri [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c2fc4da25db867b7daa7c4f618230b0@mail.gmail.com \
--to=tmarri@apm.com \
--cc=dan.j.williams@intel.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sr@denx.de \
--cc=tmarri@amcc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).