Re: next-20170220 failed to build on PowerPC

[Abdul Haleem <abdhalee@linux.vnet.ibm.com>]

On 2017-02-20 16:25, abdul wrote:
> Hi,
> 
> next-20170220 fails to build on Power 8 (PowerVM LPAR) with these 
> errors.
> 
> with same config, next-20170215 builds fine.
> 
> the config file used is attached, by default
> CONFIG_VIRT_CPU_ACCOUNTING_NATIVE was not set.
> 
> (X) Simple tick based cputime accounting
> ( ) Deterministic task and CPU time accounting
> ( ) Full dynticks CPU time accounting
> 
> arch/powerpc/kernel/time.c: In function ‘running_clock’:
> arch/powerpc/kernel/time.c:712:25: error: implicit declaration of
> function ‘cputime_to_nsecs’
> [-Werror=implicit-function-declaration]
>    return local_clock() -
> cputime_to_nsecs(kcpustat_this_cpu->cpustat[CPUTIME_STEAL]);
> 		  ^
> cc1: all warnings being treated as errors
> make[1]: *** [arch/powerpc/kernel/time.o] Error 1
> make[1]: *** Waiting for unfinished jobs....,
> 
> Note*: Problem is not seen when CONFIG_VIRT_CPU_ACCOUNTING_NATIVE is 
> enabled i.e
> 
> ( ) Simple tick based cputime accounting
> (X) Deterministic task and CPU time accounting
> ( ) Full dynticks CPU time accounting
> 

Bisecting resulted in below commit causing the build break.

commit f22d6df0b23e66b6d9058e2570402606a6ad069a
Author: Frederic Weisbecker <fweisbec@gmail.com>
Date:   Tue Jan 31 04:09:43 2017 +0100

     sched/cputime: Remove jiffies based cputime

     This cputime_t implementation is now unused, we can remove it.

     Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
     Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
     Cc: Fenghua Yu <fenghua.yu@intel.com>
     Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
     Cc: Linus Torvalds <torvalds@linux-foundation.org>
     Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
     Cc: Michael Ellerman <mpe@ellerman.id.au>
     Cc: Paul Mackerras <paulus@samba.org>
     Cc: Peter Zijlstra <peterz@infradead.org>
     Cc: Rik van Riel <riel@redhat.com>
     Cc: Stanislaw Gruszka <sgruszka@redhat.com>
     Cc: Thomas Gleixner <tglx@linutronix.de>
     Cc: Tony Luck <tony.luck@intel.com>
     Cc: Wanpeng Li <wanpeng.li@hotmail.com>
     Link: 
http://lkml.kernel.org/r/1485832191-26889-28-git-send-email-fweisbec@gmail.com
     Signed-off-by: Ingo Molnar <mingo@kernel.org>


Regard's
Abdul Haleem
IBM Linux Technology Center.