From: Ruan Jinjie <ruanjinjie@huawei.com>
To: <mpe@ellerman.id.au>, <npiggin@gmail.com>,
<christophe.leroy@csgroup.eu>, <joel@jms.id.au>,
<Julia.Lawall@inria.fr>, <linuxppc-dev@lists.ozlabs.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] powerpc/mpic_msgr: fix cast removes address space of expression warnings
Date: Fri, 30 Sep 2022 09:34:34 +0800 [thread overview]
Message-ID: <8ca0a577-67b1-a51e-2657-5a55e395d4d3@huawei.com> (raw)
In-Reply-To: <20220901085416.204378-1-ruanjinjie@huawei.com>
Ping.
On 2022/9/1 16:54, ruanjinjie wrote:
> When build Linux kernel, encounter the following warnings:
>
> ./arch/powerpc/sysdev/mpic_msgr.c:230:38: warning: cast removes address space '__iomem' of expression
> ./arch/powerpc/sysdev/mpic_msgr.c:230:27: warning: incorrect type in assignment (different address spaces)
>
> The data type of msgr->mer and msgr->base are 'u32 __iomem *', but
> converted to 'u32 *' and 'u8 *' directly and cause above warnings, now
> recover their data types to fix these warnings.
>
> Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>
> ---
> arch/powerpc/sysdev/mpic_msgr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/sysdev/mpic_msgr.c b/arch/powerpc/sysdev/mpic_msgr.c
> index 698fefaaa6dd..cbb0d24f15ba 100644
> --- a/arch/powerpc/sysdev/mpic_msgr.c
> +++ b/arch/powerpc/sysdev/mpic_msgr.c
> @@ -227,7 +227,7 @@ static int mpic_msgr_probe(struct platform_device *dev)
>
> reg_number = block_number * MPIC_MSGR_REGISTERS_PER_BLOCK + i;
> msgr->base = msgr_block_addr + i * MPIC_MSGR_STRIDE;
> - msgr->mer = (u32 *)((u8 *)msgr->base + MPIC_MSGR_MER_OFFSET);
> + msgr->mer = (u32 __iomem *)((u8 __iomem *)msgr->base + MPIC_MSGR_MER_OFFSET);
> msgr->in_use = MSGR_FREE;
> msgr->num = i;
> raw_spin_lock_init(&msgr->lock);
next prev parent reply other threads:[~2022-09-30 1:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 8:54 [PATCH -next] powerpc/mpic_msgr: fix cast removes address space of expression warnings ruanjinjie
2022-09-30 1:34 ` Ruan Jinjie [this message]
2022-09-30 6:09 ` Christophe Leroy
2022-09-30 6:37 ` Ruan Jinjie
2022-09-30 7:25 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ca0a577-67b1-a51e-2657-5a55e395d4d3@huawei.com \
--to=ruanjinjie@huawei.com \
--cc=Julia.Lawall@inria.fr \
--cc=christophe.leroy@csgroup.eu \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox