From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-bw0-f168.google.com (mail-bw0-f168.google.com [209.85.218.168]) by ozlabs.org (Postfix) with ESMTP id 20A13DDDF9 for ; Fri, 13 Feb 2009 00:36:41 +1100 (EST) Received: by bwz12 with SMTP id 12so1812182bwz.9 for ; Thu, 12 Feb 2009 05:36:39 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20090212133037.GA3651@yookeroo.seuss> References: <8cad0aa0902120123p27cfe32fg6bf08d458178c937@mail.gmail.com> <49940265.1020700@vastech.co.za> <8cad0aa0902120310g44a3bf3cla4ffa94ea9bf5dc6@mail.gmail.com> <20090212133037.GA3651@yookeroo.seuss> Date: Thu, 12 Feb 2009 14:36:39 +0100 Message-ID: <8cad0aa0902120536p3303322cvf9a7307391d195b9@mail.gmail.com> Subject: Re: [MPC8272ADS]Problem adding flash partitions inside the device tree From: Jean-Michel Hautbois To: Jean-Michel Hautbois , Pieter , linuxppc-dev@ozlabs.org Content-Type: multipart/alternative; boundary=0016e6d3766160406b0462b8cf92 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , --0016e6d3766160406b0462b8cf92 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit 2009/2/12 David Gibson > On Thu, Feb 12, 2009 at 12:10:58PM +0100, Jean-Michel Hautbois wrote: > > 2009/2/12 Pieter > > > > > Jean-Michel Hautbois wrote: > > > > Warning (reg_format): "reg" property in > > > > /localbus@f0010100/flash@0,0/partition@ff800000 has invalid length > (8 > > > > JM > > > You are missing some definitions, The #address-cells and #size-cells = > <1>; > > > tis is a snippet of teh dts i defined for my board. > > > > > > flash@0,0 { > > > #address-cells = <1>; > > > #size-cells = <1>; > > > compatible = "cfi-flash"; > > > reg = <0x0 0x0 0x08000000>; > > > bank-width = <4>; > > > device-width = <1>; > > > > > > /* set flash partition to correspond tu mtd parts in > > > u-boot*/ > > > /* 0xf8000000 */ > > > partition@0x0 { > > > label = "factory-image"; > > > reg = <0x00000000 0x01000000>; > > > }; > > > /* 0xf9000000 */ > > > partition@0x01000000 { > > > label = "app-image-1"; > > > reg = <0x01000000 0x01000000>; > > > }; > > > cheers pieter > > > > > > > Hi do have these definitions, at a higher level: > > The address-cells and size-cells definitions are not inherited. They > cover only the immediate children of the node where they appear. > Otherwise the default values apply (address-cells == 2, size-cells == > 1), which are not right for your case. > > -- > David Gibson | I'll have my music baroque, and my code > david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ > _other_ > | _way_ _around_! > http://www.ozlabs.org/~dgibson > OK, so, after having tested, I can't see any changes when booting. I do not have more mtd in /proc/mtd. JM --0016e6d3766160406b0462b8cf92 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
2009/2/12 David Gibson <david@gibson.dropbear.id.au= >
On Thu, Feb 12, 2009 at 12:10:58PM +0= 100, Jean-Michel Hautbois wrote:
> 2009/2/12 Pieter <phennin= g@vastech.co.za>
>
> > Jean-Michel Hautbois wrote:
> > > Warning (reg_format): "reg" property in
> > > /localbus@f0010100/flash@0,0/partition@ff800000 has invalid = length (8
> > > JM
> > You are missing some definitions, The #address-cells and #size-ce= lls =3D <1>;
> > tis is a snippet of teh dts i defined for my board.
> >
> >        flash@0,0 {
> >            #address-cells =3D <1= >;
> >            #size-cells =3D <1>= ;;
> >            compatible =3D "cfi= -flash";
> >            reg =3D <0x0 0x0 0x08= 000000>;
> >             bank-width =3D <4>= ;;
> >            device-width =3D <1&g= t;;
> >
> >             /* set flash partition = to correspond tu mtd parts in
> > u-boot*/
> >            /*     0xf8000= 000 */
> >            partition@0x0 {
> >                label =3D = "factory-image";
> >                reg =3D &l= t;0x00000000 0x01000000>;
> >            };
> >            /*     0xf9000= 000 */
> >            partition@0x01000000 { > >                label =3D = "app-image-1";
> >                reg =3D &l= t;0x01000000 0x01000000>;
> >            };
> > cheers pieter
> >
>
> Hi do have these definitions, at a higher level:

The address-cells and size-cells definitions are not inherited.=  They
cover only the immediate children of the node where they appear.
Otherwise the default values apply (address-cells =3D=3D 2, size-cells =3D= =3D
1), which are not right for your case.

--
David Gibson                  =  | I'll have my music baroque, and my code
david AT gibson.= dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_                     &nbs= p;          | _way_ _around_!
http://www.o= zlabs.org/~dgibson
OK, so, after having tested, I can't see any = changes when booting.
I do not have more mtd in /proc/mtd.

JM
--0016e6d3766160406b0462b8cf92--