From: christophe lombard <clombard@linux.vnet.ibm.com>
To: Vaibhav Jain <vaibhav@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org, fbarrat@linux.vnet.ibm.com,
andrew.donnellan@au1.ibm.com
Subject: Re: [PATCH V2] cxl: Fix memory page not handled
Date: Tue, 26 Sep 2017 10:15:59 +0200 [thread overview]
Message-ID: <8d0099bd-a470-7f8c-a665-9540e012361e@linux.vnet.ibm.com> (raw)
In-Reply-To: <87mv5imdwr.fsf@vajain21.in.ibm.com>
Le 26/09/2017 à 03:44, Vaibhav Jain a écrit :
> Hi Christophe,
>
> A minor nitpick
>
> Christophe Lombard <clombard@linux.vnet.ibm.com> writes:
>
>> + for (dar = (addr & ~(page_size - 1)); dar < (addr + size); dar += page_size) {
>> + if (dar < vma->vm_start || dar > vma->vm_end) {
> Code comment in mm_types.h for vm_end says it "The first byte after our
> end address within vm_mm". So this condition should be
> (dar < vma->vm_start || dar >= vma->vm_end)
>
> ~ Vaibhav
You are right. Thanks for the review
prev parent reply other threads:[~2017-09-26 8:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 8:58 [PATCH V2] cxl: Fix memory page not handled Christophe Lombard
2017-09-25 12:24 ` Frederic Barrat
2017-09-26 1:20 ` Andrew Donnellan
2017-09-26 1:44 ` Vaibhav Jain
2017-09-26 2:00 ` Andrew Donnellan
2017-09-26 8:15 ` christophe lombard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d0099bd-a470-7f8c-a665-9540e012361e@linux.vnet.ibm.com \
--to=clombard@linux.vnet.ibm.com \
--cc=andrew.donnellan@au1.ibm.com \
--cc=fbarrat@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=vaibhav@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).