From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3xR5d34NMKzDqkF for ; Tue, 8 Aug 2017 04:28:23 +1000 (AEST) Subject: Re: block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init() To: SF Markus Elfring , linuxppc-dev@lists.ozlabs.org Cc: Benjamin Herrenschmidt , Michael Ellerman , Paul Mackerras , LKML , kernel-janitors@vger.kernel.org References: From: Geoff Levand Message-ID: <8d140d00-935c-da0a-ff2e-167abe642bda@infradead.org> Date: Mon, 7 Aug 2017 11:28:12 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 08/07/2017 09:27 AM, SF Markus Elfring wrote: >>> Omit an extra message for a memory allocation failure in this function. >>> >>> This issue was detected by using the Coccinelle software. >> >> NACK >> >> When a user asks me for help I would certainly like to get >> 'Could not allocate cache tags' as apposed to nothing, > > Do you find the default allocation failure report insufficient? The default is OK. I didn't consider one would be triggered by the kzalloc failure. >> since the return value of ps3vram_cache_init() is not checked. > > Are there any more update candidates to consider for better exception handling? The return of ps3vram_cache_init() should be checked. Feel free to propose others. -Geoff