From: Uma Krishnan <ukrishn@linux.vnet.ibm.com>
To: linux-scsi@vger.kernel.org,
James Bottomley <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"Matthew R. Ochs" <mrochs@linux.vnet.ibm.com>,
"Manoj N. Kumar" <manoj@linux.vnet.ibm.com>
Cc: Brian King <brking@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org, Ian Munsie <imunsie@au1.ibm.com>,
Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
Frederic Barrat <fbarrat@linux.vnet.ibm.com>,
Christophe Lombard <clombard@linux.vnet.ibm.com>
Subject: Re: [PATCH v2 10/14] cxlflash: Remove AFU command lock
Date: Wed, 30 Nov 2016 16:12:28 -0600 [thread overview]
Message-ID: <8d9dd4f3-ff12-8a0c-16ee-da2a28b9f275@linux.vnet.ibm.com> (raw)
In-Reply-To: <1480380162-60533-1-git-send-email-ukrishn@linux.vnet.ibm.com>
> From: "Matthew R. Ochs" <mrochs@linux.vnet.ibm.com>
>
> The original design of the cxlflash driver required AFU commands
> to convey state information across multiple threads. The IOASA
> "host use" byte was used to track if a command was done, errored,
> or timed out. A per-command spin lock was used to serialize access
> to this byte. As this is no longer required with the introduction
> of completions and various refactoring over time, the spin lock,
> state tracking, and associated code can be removed. To support the
> simplification, the wait_resp() routine is refactored to return a
> success or failure. Additionally, as the simplification to the
> AFU internal command routine, explicit assignments of AFU command
> fields to zero are removed as the memory is zeroed upon allocation.
>
> Signed-off-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
Acked-by: Uma Krishnan <ukrishn@linux.vnet.ibm.com>
next prev parent reply other threads:[~2016-11-30 22:11 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 0:39 [PATCH v2 00/14] cxlflash: Fixes, enhancements, cleanup and staging Uma Krishnan
2016-11-29 0:41 ` [PATCH v2 01/14] cxlflash: Set sg_tablesize to 1 instead of SG_NONE Uma Krishnan
2016-11-29 0:41 ` [PATCH v2 02/14] cxlflash: Fix crash in cxlflash_restore_luntable() Uma Krishnan
2016-11-29 0:41 ` [PATCH v2 03/14] cxlflash: Improve context_reset() logic Uma Krishnan
2016-11-29 0:41 ` [PATCH v2 04/14] cxlflash: Avoid command room violation Uma Krishnan
2016-11-29 17:04 ` Matthew R. Ochs
2016-11-29 0:42 ` [PATCH v2 05/14] cxlflash: Remove unused buffer from AFU command Uma Krishnan
2016-11-30 22:03 ` Uma Krishnan
2016-11-29 0:42 ` [PATCH v2 06/14] cxlflash: Allocate memory instead of using command pool for AFU sync Uma Krishnan
2016-11-30 22:04 ` Uma Krishnan
2016-11-29 0:42 ` [PATCH v2 07/14] cxlflash: Use cmd_size for private commands Uma Krishnan
2016-11-30 22:05 ` Uma Krishnan
2016-11-29 0:42 ` [PATCH v2 08/14] cxlflash: Remove private command pool Uma Krishnan
2016-11-30 22:11 ` Uma Krishnan
2016-11-29 0:42 ` [PATCH v2 09/14] cxlflash: Wait for active AFU commands to timeout upon tear down Uma Krishnan
2016-11-30 22:11 ` Uma Krishnan
2016-11-29 0:42 ` [PATCH v2 10/14] cxlflash: Remove AFU command lock Uma Krishnan
2016-11-30 22:12 ` Uma Krishnan [this message]
2016-11-29 0:42 ` [PATCH v2 11/14] cxlflash: Cleanup send_tmf() Uma Krishnan
2016-11-30 22:12 ` Uma Krishnan
2016-11-29 0:43 ` [PATCH v2 12/14] cxlflash: Cleanup queuecommand() Uma Krishnan
2016-11-30 22:13 ` Uma Krishnan
2016-11-29 0:43 ` [PATCH v2 13/14] cxlflash: Migrate IOARRIN specific routines to function pointers Uma Krishnan
2016-11-30 22:13 ` Uma Krishnan
2016-11-29 0:43 ` [PATCH v2 14/14] cxlflash: Migrate scsi command pointer to AFU command Uma Krishnan
2016-11-30 22:14 ` Uma Krishnan
2016-11-30 16:42 ` [PATCH v2 00/14] cxlflash: Fixes, enhancements, cleanup and staging Martin K. Petersen
2016-12-01 0:55 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d9dd4f3-ff12-8a0c-16ee-da2a28b9f275@linux.vnet.ibm.com \
--to=ukrishn@linux.vnet.ibm.com \
--cc=andrew.donnellan@au1.ibm.com \
--cc=brking@linux.vnet.ibm.com \
--cc=clombard@linux.vnet.ibm.com \
--cc=fbarrat@linux.vnet.ibm.com \
--cc=imunsie@au1.ibm.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=manoj@linux.vnet.ibm.com \
--cc=martin.petersen@oracle.com \
--cc=mrochs@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).