[PATCH 0/2] ASoC: fsl_sai: support the i.MX952 platform

[PATCH 0/2] ASoC: fsl_sai: support the i.MX952 platform

[Shengjiu Wang]

Update dt binding document and driver to support i.MX952 platform

Shengjiu Wang (2):
  ASoC: dt-bindings: fsl,sai: Add support for i.MX952 platform
  ASoC: fsl_sai: Add support for i.MX952 platform

 .../devicetree/bindings/sound/fsl,sai.yaml          |  1 +
 sound/soc/fsl/fsl_sai.c                             | 13 +++++++++++++
 2 files changed, 14 insertions(+)

-- 
2.34.1

[PATCH 1/2] ASoC: dt-bindings: fsl,sai: Add support for i.MX952 platform

[Shengjiu Wang]

Add new compatible string 'fsl,imx952-sai' for i.MX952 platform

Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
---
 Documentation/devicetree/bindings/sound/fsl,sai.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/sound/fsl,sai.yaml b/Documentation/devicetree/bindings/sound/fsl,sai.yaml
index 0d733e5b08a4..d838ee0b61cb 100644
--- a/Documentation/devicetree/bindings/sound/fsl,sai.yaml
+++ b/Documentation/devicetree/bindings/sound/fsl,sai.yaml
@@ -44,6 +44,7 @@ properties:
       - items:
           - enum:
               - fsl,imx94-sai
+              - fsl,imx952-sai
           - const: fsl,imx95-sai
 
   reg:
-- 
2.34.1

[PATCH 2/2] ASoC: fsl_sai: Add support for i.MX952 platform

[Shengjiu Wang]

Add compatible string and specific soc data to support SAI on i.MX952
platform.

Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
---
 sound/soc/fsl/fsl_sai.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c
index 2fa14fbdfe1a..c025041dc079 100644
--- a/sound/soc/fsl/fsl_sai.c
+++ b/sound/soc/fsl/fsl_sai.c
@@ -1765,6 +1765,18 @@ static const struct fsl_sai_soc_data fsl_sai_imx95_data = {
 	.max_burst = {8, 8},
 };
 
+static const struct fsl_sai_soc_data fsl_sai_imx952_data = {
+	.use_imx_pcm = true,
+	.use_edma = true,
+	.fifo_depth = 128,
+	.reg_offset = 8,
+	.mclk0_is_mclk1 = false,
+	.pins = 8,
+	.flags = 0,
+	.max_register = FSL_SAI_MCTL,
+	.max_burst = {8, 8},
+};
+
 static const struct of_device_id fsl_sai_ids[] = {
 	{ .compatible = "fsl,vf610-sai", .data = &fsl_sai_vf610_data },
 	{ .compatible = "fsl,imx6sx-sai", .data = &fsl_sai_imx6sx_data },
@@ -1778,6 +1790,7 @@ static const struct of_device_id fsl_sai_ids[] = {
 	{ .compatible = "fsl,imx8mn-sai", .data = &fsl_sai_imx8mn_data },
 	{ .compatible = "fsl,imx93-sai", .data = &fsl_sai_imx93_data },
 	{ .compatible = "fsl,imx95-sai", .data = &fsl_sai_imx95_data },
+	{ .compatible = "fsl,imx952-sai", .data = &fsl_sai_imx952_data },
 	{ /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(of, fsl_sai_ids);
-- 
2.34.1

Re: [PATCH 1/2] ASoC: dt-bindings: fsl,sai: Add support for i.MX952 platform

[Maud Spierings]

> Add new compatible string 'fsl,imx952-sai' for i.MX952 platform
> 
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
>  Documentation/devicetree/bindings/sound/fsl,sai.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/fsl,sai.yaml b/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> index 0d733e5b08a4..d838ee0b61cb 100644
> --- a/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> +++ b/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> @@ -44,6 +44,7 @@ properties:
>        - items:
>            - enum:
>                - fsl,imx94-sai
> +              - fsl,imx952-sai
>            - const: fsl,imx95-sai

I don't think this new one should have the fallback on imx95, given that 
you are adding a new match compatible in the driver, so it is not 
compatible with the "fsl,imx95-sai" data.

It should be a new separate entry.

Kind regards,
Maud

>    reg:
> -- 
> 2.34.1

Re: [PATCH 2/2] ASoC: fsl_sai: Add support for i.MX952 platform

[Maud Spierings]

> 
> Add compatible string and specific soc data to support SAI on i.MX952
> platform.
> 
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
>  sound/soc/fsl/fsl_sai.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c
> index 2fa14fbdfe1a..c025041dc079 100644
> --- a/sound/soc/fsl/fsl_sai.c
> +++ b/sound/soc/fsl/fsl_sai.c
> @@ -1765,6 +1765,18 @@ static const struct fsl_sai_soc_data fsl_sai_imx95_data = {
>  	.max_burst = {8, 8},
>  };
>  
> +static const struct fsl_sai_soc_data fsl_sai_imx952_data = {
> +	.use_imx_pcm = true,
> +	.use_edma = true,
> +	.fifo_depth = 128,
> +	.reg_offset = 8,
> +	.mclk0_is_mclk1 = false,
> +	.pins = 8,
> +	.flags = 0,
> +	.max_register = FSL_SAI_MCTL,
> +	.max_burst = {8, 8},
> +};
> +
>  static const struct of_device_id fsl_sai_ids[] = {
>  	{ .compatible = "fsl,vf610-sai", .data = &fsl_sai_vf610_data },
>  	{ .compatible = "fsl,imx6sx-sai", .data = &fsl_sai_imx6sx_data },
> @@ -1778,6 +1790,7 @@ static const struct of_device_id fsl_sai_ids[] = {
>  	{ .compatible = "fsl,imx8mn-sai", .data = &fsl_sai_imx8mn_data },
>  	{ .compatible = "fsl,imx93-sai", .data = &fsl_sai_imx93_data },
>  	{ .compatible = "fsl,imx95-sai", .data = &fsl_sai_imx95_data },
> +	{ .compatible = "fsl,imx952-sai", .data = &fsl_sai_imx952_data },
>  	{ /* sentinel */ }
>  };
>  MODULE_DEVICE_TABLE(of, fsl_sai_ids);
> -- 
> 2.34.1

scratch my comment on patch 1, drop this patch. the new data struct is 
the exact same as the imx95 one.

Keep the fallback compatible and let it match against that instead of 
introducing a new one in the driver.

Kind regards,
Maud