From: Mahesh Jagannath Salgaonkar <mahesh@linux.vnet.ibm.com>
To: Reza Arbab <arbab@linux.ibm.com>
Cc: Santosh Sivaraj <santosh@fossix.org>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
Mahesh Salgaonkar <mahesh@linux.ibm.com>,
Nicholas Piggin <npiggin@gmail.com>,
Chandan Rajendra <chandan@linux.vnet.ibm.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 05/13] powerpc/mce: Allow notifier callback to handle MCE
Date: Mon, 24 Jun 2019 10:49:11 +0530 [thread overview]
Message-ID: <8eb93794-fdbc-5f24-08d7-d698b6ce6f06@linux.vnet.ibm.com> (raw)
In-Reply-To: <20190623021401.al2iyyhxvkf7csep@arbab-vm>
On 6/23/19 7:44 AM, Reza Arbab wrote:
> Hi Mahesh,
>
> On Fri, Jun 21, 2019 at 12:35:08PM +0530, Mahesh Jagannath Salgaonkar
> wrote:
>> On 6/21/19 6:27 AM, Santosh Sivaraj wrote:
>>> - blocking_notifier_call_chain(&mce_notifier_list, 0, &evt);
>>> + rc = blocking_notifier_call_chain(&mce_notifier_list, 0, evt);
>>> + if (rc & NOTIFY_STOP_MASK) {
>>> + evt->disposition = MCE_DISPOSITION_RECOVERED;
>>> + regs->msr |= MSR_RI;
>>
>> What is the reason for setting MSR_RI ? I don't think this is a good
>> idea. MSR_RI = 0 means system got MCE interrupt when SRR0 and SRR1
>> contents were live and was overwritten by MCE interrupt. Hence this
>> interrupt is unrecoverable irrespective of whether machine check handler
>> recovers from it or not.
>
> Good catch! I think this is an artifact from when I was first trying to
> get all this working.
>
> Instead of setting MSR_RI, we should probably just check for it. Ie,
>
> if ((rc & NOTIFY_STOP_MASK) && (regs->msr & MSR_RI)) {
> evt->disposition = MCE_DISPOSITION_RECOVERED;
Yup, looks good to me.
Thanks,
-Mahesh.
next prev parent reply other threads:[~2019-06-24 5:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 4:55 [PATCH 00/13] powerpc: implement machine check safe memcpy Santosh Sivaraj
2019-06-21 4:55 ` [PATCH 01/13] powerpc/mce: Make machine_check_ue_event() static Santosh Sivaraj
2019-06-21 4:55 ` [PATCH 02/13] powerpc/mce: Bug fixes for MCE handling in kernel space Santosh Sivaraj
2019-06-21 4:55 ` [PATCH 03/13] powerpc/mce: Add MCE notification chain Santosh Sivaraj
2019-06-21 4:55 ` [PATCH 04/13] powerpc/mce: Move machine_check_ue_event() call Santosh Sivaraj
2019-06-21 4:55 ` [PATCH 05/13] powerpc/mce: Allow notifier callback to handle MCE Santosh Sivaraj
2019-06-21 7:05 ` Mahesh Jagannath Salgaonkar
2019-06-23 2:14 ` Reza Arbab
2019-06-24 5:19 ` Mahesh Jagannath Salgaonkar [this message]
2019-06-21 4:55 ` [PATCH 06/13] powerpc/mce: Do not process notifier-handled UE events Santosh Sivaraj
2019-06-21 4:55 ` [PATCH 07/13] powerpc/mce: Add fixup address to " Santosh Sivaraj
2019-06-21 4:55 ` [PATCH 08/13] powerpc/memcpy: Add memcpy_mcsafe for pmem Santosh Sivaraj
2019-06-29 8:55 ` christophe leroy
2019-06-21 4:55 ` [PATCH 09/13] powerpc/mce: Handle memcpy_mcsafe() Santosh Sivaraj
2019-06-21 4:55 ` [PATCH 10/13] powerpc/mce: Enable MCE notifiers in external modules Santosh Sivaraj
2019-06-21 4:55 ` [PATCH 11/13] powerpc/64s: Save r13 in machine_check_common_early Santosh Sivaraj
2019-06-21 11:47 ` Mahesh J Salgaonkar
2019-06-21 23:21 ` Nicholas Piggin
2019-06-23 2:33 ` Reza Arbab
2019-06-21 4:55 ` [PATCH 12/13] powerpc/memcpy_mcsafe: return remaining bytes Santosh Sivaraj
2019-06-21 4:55 ` [PATCH 13/13] powerpc: add machine check safe copy_to_user Santosh Sivaraj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8eb93794-fdbc-5f24-08d7-d698b6ce6f06@linux.vnet.ibm.com \
--to=mahesh@linux.vnet.ibm.com \
--cc=aneesh.kumar@linux.ibm.com \
--cc=arbab@linux.ibm.com \
--cc=chandan@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=santosh@fossix.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).