From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55AC5C001DB for ; Tue, 15 Aug 2023 00:35:17 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Pl5aQI0m; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4RPsjv2yhXz3cB1 for ; Tue, 15 Aug 2023 10:35:15 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Pl5aQI0m; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=linux.intel.com (client-ip=134.134.136.24; helo=mgamail.intel.com; envelope-from=baolu.lu@linux.intel.com; receiver=lists.ozlabs.org) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4RPshv4J6cz2yRV for ; Tue, 15 Aug 2023 10:34:21 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692059664; x=1723595664; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=VSM1w+2GQF5FWr9+uAkx0UUWSnoPqxj5esYUGnBEoIA=; b=Pl5aQI0mCrO2l74usuOI2jaYhpujqn1sPF2hHxXt2uiFV0kw2R9lKySC lTlDGlcZCRP7ZDo2CE88s+mBG95TToRjwyXjdILm4cKswQAG3d0QVWCZY 9nPR0Xj58isnZqc0QqLbmSn0L6kJ8FVVBG45mrX1p+Etk375URaPpdpv8 5rSMBA7Tz9PzqSQor9J4X2dgB8ZZhWa5zI4AhBJfDL5EwoYIjAYZUrVFl Yj5X2Tr1gF0iQTIkPoECX08lEr6PzeajdcbJqqQ9e4bTlXAjAtxTMzRpP HcoUoLgVJKWCPpEhP59iRBs+JcyUeXDP+Y0h5/FHMHdkKZyvf+Yre7jKW Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10802"; a="374938115" X-IronPort-AV: E=Sophos;i="6.01,173,1684825200"; d="scan'208";a="374938115" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2023 17:34:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10802"; a="823660205" X-IronPort-AV: E=Sophos;i="6.01,173,1684825200"; d="scan'208";a="823660205" Received: from wanglu5-mobl.ccr.corp.intel.com (HELO [10.254.215.149]) ([10.254.215.149]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2023 17:34:05 -0700 Message-ID: <8f3ce115-7489-640a-b1fb-a6fb6cfb1682@linux.intel.com> Date: Tue, 15 Aug 2023 08:34:03 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v6 07/25] iommu/mtk_iommu_v1: Implement an IDENTITY domain To: Jason Gunthorpe References: <7-v6-e8114faedade+425-iommu_all_defdom_jgg@nvidia.com> <7b6b8118-813a-f4cd-1067-d209d2b40025@linux.intel.com> Content-Language: en-US From: Baolu Lu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , Matthew Rosato , Matthias Brugger , Thierry Reding , Jernej Skrabec , Alim Akhtar , Dmitry Osipenko , Steven Price , Will Deacon , Marek Szyprowski , linux-s390@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Samuel Holland , Joerg Roedel , Russell King , Jonathan Hunter , linux-rockchip@lists.infradead.org, iommu@lists.linux.dev, Andy Gross , Nicolin Chen , Yong Wu , Orson Zhai , Gerald Schaefer , Thierry Reding , linux-sunxi@lists.linux.dev, Rob Clark , Kevin Tian , Niklas Schnelle , linux-arm-msm@vger.kernel.org, Nicholas Piggin , Krishna Reddy , linux-mediatek@lists.infradead.org, Baolin Wang , linux-tegra@vger.kernel.org, Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno , Robin Murphy , Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Chunyan Zhang , linuxppc-dev@lists.ozlabs.org, baolu.lu@linux.intel.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 2023/8/14 22:34, Jason Gunthorpe wrote: >>> @@ -443,7 +459,7 @@ static int mtk_iommu_v1_create_mapping(struct device *dev, struct of_phandle_arg >>> static int mtk_iommu_v1_def_domain_type(struct device *dev) >>> { >>> - return IOMMU_DOMAIN_UNMANAGED; >>> + return IOMMU_DOMAIN_IDENTITY; >> def_domain_type can't be used for this purpose. But this seems to be a >> temporary code, as it will be removed in patch 09/25. > It looked OK when I checked it, mkt_v1 is really confusing what it > tries to do, but it should call probe_finalize and basically do the > same hacky thing as what UNMANAGED was trying to accomplish. > > Did you see something else? No. Best regards, baolu