Re: [PATCH v8 0/3] generic and PowerPC SED Opal keystore

[Greg Joyce <gjoyce@linux.vnet.ibm.com>]

Hi Jens,

I've addressed all the comments/issues on v7 of the patchset and
haven't received any feedback on v8. Is there anything else that you'd
like to see before this can be included?

Thanks,
Greg

On Wed, 2023-10-04 at 15:19 -0500, gjoyce@linux.vnet.ibm.com wrote:
> From: Greg Joyce <gjoyce@linux.vnet.ibm.com>
> 
> This patchset has gone through numerous rounds of review and
> all comments/suggetions have been addressed. The reviews have
> covered all relevant areas including reviews by block and keyring
> developers as well as the SED Opal maintainer.
> 
> TCG SED Opal is a specification from The Trusted Computing Group
> that allows self encrypting storage devices (SED) to be locked at
> power on and require an authentication key to unlock the drive.
> 
> PowerPC/pseries versions of key functions provide read/write access
> to SED Opal keys in the PLPKS keystore.
> 
> The SED block driver has been modified to read the SED Opal
> keystore to populate a key in the SED Opal keyring. Changes to the
> SED Opal key will be written to the SED Opal keystore.
> 
> 
> Changelog
> v8:     - rebased to 6.6-rc4
> 	- fixed issues using clang (thanks Nathan Chancellor and Nick
> 	  Desaulniers)
> 	- fixed crash if PLPKS is not present for pseries (thanks
> Michael
> 	  Ellerman)
> 
> v7:     - rebased to for-6.5/block
> 
> v6:     - squashed two commits (suggested by Andrew Donnellan)
> 
> v5:     - updated to reflect changes in PLPKS API
> 
> v4:
>         - scope reduced to cover just SED Opal keys
>         - base SED Opal keystore is now in SED block driver
>         - removed use of enum to indicate type
>         - refactored common code into common function that read and
>           write use
>         - removed cast to void
>         - added use of SED Opal keystore functions to SED block
> driver
> 
> v3:
>         - No code changes, but per reviewer requests, adding
> additional
>           mailing lists(keyring, EFI) for wider review.
> 
> v2:
>         - Include feedback from Gregory Joyce, Eric Richter and
>           Murilo Opsfelder Araujo.
>         - Include suggestions from Michael Ellerman.
>         - Moved a dependency from generic SED code to this patchset.
>           This patchset now builds of its own.
> 
> 
> 
> 
> Greg Joyce (3):
>   block:sed-opal: SED Opal keystore
>   block: sed-opal: keystore access for SED Opal keys
>   powerpc/pseries: PLPKS SED Opal keystore support
> 
>  arch/powerpc/platforms/pseries/Kconfig        |   6 +
>  arch/powerpc/platforms/pseries/Makefile       |   1 +
>  .../powerpc/platforms/pseries/plpks_sed_ops.c | 131
> ++++++++++++++++++
>  block/Kconfig                                 |   1 +
>  block/sed-opal.c                              |  18 ++-
>  include/linux/sed-opal-key.h                  |  26 ++++
>  6 files changed, 181 insertions(+), 2 deletions(-)
>  create mode 100644 arch/powerpc/platforms/pseries/plpks_sed_ops.c
>  create mode 100644 include/linux/sed-opal-key.h
>