From: Arnd Bergmann <arnd@arndb.de>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: Remove all usages of NO_IRQ
Date: Thu, 08 Sep 2016 11:28:22 +0200 [thread overview]
Message-ID: <9024911.juYcnHzy1x@wuerfel> (raw)
In-Reply-To: <87lgz2lpk3.fsf@concordia.ellerman.id.au>
On Thursday, September 8, 2016 7:16:12 PM CEST Michael Ellerman wrote:
>
> The rest below I haven't looked at yet, I'm not entirely clear on which
> FSL pieces are able to build on arm.
>
> > drivers/dma/bestcomm/bestcomm.c: if (tsk->irq != NO_IRQ)
> > drivers/dma/fsl_raid.c: if (chan->irq == NO_IRQ) {
> > drivers/dma/fsldma.c: if (fdev->irq != NO_IRQ) {
> > drivers/dma/mpc512x_dma.c: if (mdma->irq == NO_IRQ) {
> > drivers/edac/mpc85xx_edac.c: pdata->irq = NO_IRQ;
> > drivers/iommu/fsl_pamu.c: if (irq != NO_IRQ)
> > drivers/media/platform/fsl-viu.c: if (viu_irq == NO_IRQ) {
> > drivers/mtd/nand/mpc5121_nfc.c: if (prv->irq == NO_IRQ) {
> > drivers/net/ethernet/freescale/fs_enet/mac-fcc.c: if (fep->interrupt == NO_IRQ)
> > drivers/net/ethernet/freescale/fs_enet/mac-fec.c: if (fep->interrupt == NO_IRQ)
> > drivers/net/ethernet/freescale/fs_enet/mac-scc.c: if (fep->interrupt == NO_IRQ)
> > drivers/soc/fsl/qe/qe_ic.c: return NO_IRQ;
> > drivers/spi/spi-mpc52xx.c: if (status && (irq != NO_IRQ))
> > drivers/tty/ehv_bytechan.c: if (stdout_irq == NO_IRQ) {
> > drivers/tty/serial/cpm_uart/cpm_uart_core.c: if (pinfo->port.irq == NO_IRQ) {
> > drivers/uio/uio_fsl_elbc_gpcm.c: if (irq != NO_IRQ) {
> > drivers/usb/host/ehci-grlib.c: if (irq == NO_IRQ) {
> > drivers/usb/host/ehci-ppc-of.c: if (irq == NO_IRQ) {
> > drivers/usb/host/fhci-hcd.c: if (usb_irq == NO_IRQ) {
> > drivers/usb/host/ohci-ppc-of.c: if (irq == NO_IRQ) {
> > drivers/usb/host/uhci-grlib.c: if (irq == NO_IRQ) {
> > drivers/video/fbdev/mb862xx/mb862xxfbdrv.c: if (par->irq == NO_IRQ) {
> > drivers/virt/fsl_hypervisor.c: if (!handle || (irq == NO_IRQ)) {
> > include/soc/fsl/qe/qe_ic.h: if (cascade_irq != NO_IRQ)
None of these are used on ARM at the moment (as of linux-next yesterday),
they would have shown up in my randconfig tests otherwise.
The "qe" stuff is the only thing that will likely get used on ARM
in the future, but the usage of NO_IRQ in that driver is actually
wrong on ARM, so that has to be fixed anyway before we can use it.
Arnd
next prev parent reply other threads:[~2016-09-08 9:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 11:53 [PATCH] powerpc: Remove all usages of NO_IRQ Michael Ellerman
2016-09-06 14:22 ` Arnd Bergmann
2016-09-08 9:16 ` Michael Ellerman
2016-09-08 9:28 ` Arnd Bergmann [this message]
2016-09-25 3:00 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9024911.juYcnHzy1x@wuerfel \
--to=arnd@arndb.de \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).