From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47346C3DA4A for ; Mon, 19 Aug 2024 11:56:36 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4WnWKG75GWz2y1W; Mon, 19 Aug 2024 21:56:34 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=savoirfairelinux.com Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=208.88.110.44 Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=savoirfairelinux.com header.i=@savoirfairelinux.com header.a=rsa-sha256 header.s=DFC430D2-D198-11EC-948E-34200CB392D2 header.b=AaMIVeoU; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=savoirfairelinux.com (client-ip=208.88.110.44; helo=mail.savoirfairelinux.com; envelope-from=elinor.montmasson@savoirfairelinux.com; receiver=lists.ozlabs.org) X-Greylist: delayed 358 seconds by postgrey-1.37 at boromir; Mon, 19 Aug 2024 21:49:36 AEST Received: from mail.savoirfairelinux.com (mail.savoirfairelinux.com [208.88.110.44]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4WnW9D2PHDz2xy3 for ; Mon, 19 Aug 2024 21:49:34 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by mail.savoirfairelinux.com (Postfix) with ESMTP id 41B869C5BDF; Mon, 19 Aug 2024 07:43:31 -0400 (EDT) Received: from mail.savoirfairelinux.com ([127.0.0.1]) by localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavis, port 10032) with ESMTP id l0-j1zBEH9ZD; Mon, 19 Aug 2024 07:43:30 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.savoirfairelinux.com (Postfix) with ESMTP id 4D1A09C5F74; Mon, 19 Aug 2024 07:43:30 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.savoirfairelinux.com 4D1A09C5F74 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=savoirfairelinux.com; s=DFC430D2-D198-11EC-948E-34200CB392D2; t=1724067810; bh=g3AsLUqBfKMisCl4I03Q1DAj0/8iriOUEYeW7RNSf2s=; h=Date:From:To:Message-ID:MIME-Version; b=AaMIVeoUp0XGvy58oS1QXH6phQNWz5ic5K/PnB2LvOWK38amBy7c5YOWrudkWD0Vp o4RmMP9VB8zhaet1baBcMCZUWWGHuBnA+M6SZDaP61Bp+yNSalbzTgvVPUV4LN1PQz 92OLI92ya8VTtQA1BtmYKMyxy+AzdNKjXsxi8XldIYouc91GD+WFFtf5a6uxySlY50 vv5ntTjj6Z8w3hFYFimazNvrJEd52F1UpVF2e2BPIx6iEvyvQrZaAwVyuEKVbVEMTm e9cmcUFdt5RoVKhg6s+8b2NJCjQLLQg3JTAUXTNse/Qgb0DWgXWQ/qd5p64rZ65VOR WSPSc2oOYP2Yg== X-Virus-Scanned: amavis at mail.savoirfairelinux.com Received: from mail.savoirfairelinux.com ([127.0.0.1]) by localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavis, port 10026) with ESMTP id G2C6bNsOuPV7; Mon, 19 Aug 2024 07:43:30 -0400 (EDT) Received: from mail.savoirfairelinux.com (mail.savoirfairelinux.com [192.168.48.237]) by mail.savoirfairelinux.com (Postfix) with ESMTP id E8A2E9C5BDF; Mon, 19 Aug 2024 07:43:29 -0400 (EDT) Date: Mon, 19 Aug 2024 07:43:29 -0400 (EDT) From: Elinor Montmasson To: Shawn Guo Cc: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , Russell King , Catalin Marinas , Will Deacon , Jaroslav Kysela , Takashi Iwai , shengjiu wang , Xiubo Lee , Nicolin Chen , Pengutronix Kernel Team , linux-sound , devicetree , imx , linux-arm-kernel , linux-kernel , alsa-devel , linuxppc-dev , Philip-Dylan Gleonec Message-ID: <905560330.155045.1724067809890.JavaMail.zimbra@savoirfairelinux.com> In-Reply-To: References: <20240627083104.123357-1-elinor.montmasson@savoirfairelinux.com> <20240627083104.123357-7-elinor.montmasson@savoirfairelinux.com> Subject: Re: [PATCH v6 6/7] arm64: dts: imx8m: update spdif sound card node properties X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Post: List-Subscribe: , , List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Mailer: Zimbra 8.8.15_GA_4581 (ZimbraWebClient - GC112 (Linux)/8.8.15_GA_4581) Thread-Topic: arm64: dts: imx8m: update spdif sound card node properties Thread-Index: LseD1k2NMHpDg9FbVlB5JHSqjmcCfQ== > From: "Shawn Guo" > Sent: Sunday, 4 August, 2024 16:31:11 > On Thu, Jun 27, 2024 at 10:31:03AM +0200, Elinor Montmasson wrote: >> The merge of imx-spdif driver into fsl-asoc-card brought >> new DT properties that can be used with the "fsl,imx-audio-spdif" >> compatible: >> * The "spdif-controller" property from imx-spdif is named "audio-cpu" >> in fsl-asoc-card. >> * fsl-asoc-card uses codecs explicitly declared in DT >> with "audio-codec". >> With an S/PDIF, codec drivers spdif_transmitter and >> spdif_receiver should be used. >> Driver imx-spdif used instead the dummy codec and a pair of >> boolean properties, "spdif-in" and "spdif-out". >> >> While backward compatibility is kept to support properties >> "spdif-controller", "spdif-in" and "spdif-out", using new properties has >> several benefits: >> * "audio-cpu" and "audio-codec" are more generic names reflecting >> that the fsl-asoc-card driver supports multiple hardware. >> They are properties already used by devices using the >> fsl-asoc-card driver. >> They are also similar to properties of simple-card: "cpu" and "codec". >> * "spdif-in" and "spdif-out" imply the use of the dummy codec in the >> driver. However, there are already two codec drivers for the S/PDIF, >> spdif_transmitter and spdif_receiver. >> It is better to declare S/PDIF Tx and Rx devices in a DT, and then >> reference them with "audio-codec" than using the dummy codec. >> >> For those reasons, this commit updates in-tree DTs to use the new >> properties: >> * Rename "spdif-controller" property to "audio-cpu". >> * Declare S/PDIF transmitter and/or receiver devices, and use them with >> the "audio-codec" property instead of "spdif-out" and/or "spdif-in". >> >> These modifications were tested only on an imx8mn-evk board. >> >> Note that out-of-tree and old DTs are still supported. >> >> Signed-off-by: Elinor Montmasson >> --- >> arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 15 +++++++++--- >> arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi | 15 +++++++++--- >> arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 24 +++++++++++++++---- >> 3 files changed, 43 insertions(+), 11 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi >> b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi >> index 90d1901df2b1..348855a41852 100644 >> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi >> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi >> @@ -180,12 +180,21 @@ cpu { >> }; >> }; >> >> + spdif_out: spdif-out { >> + #sound-dai-cells = <0>; >> + compatible = "linux,spdif-dit"; > > It's recommended that the property list begins with 'compatible'. Could > you flip them? > Yes I'll will do this quickly, thank you. Regards, Elinor Montmasson