From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 4EF46DDE29 for ; Wed, 1 Aug 2007 08:13:34 +1000 (EST) In-Reply-To: <1185918267.5495.505.camel@localhost.localdomain> References: <11851892302391-git-send-email-g.chen@freescale.com> <11851892311178-git-send-email-g.chen@freescale.com> <1185228277.5439.141.camel@localhost.localdomain> <1185232974.13740.11.camel@concordia.ozlabs.ibm.com> <1185918267.5495.505.camel@localhost.localdomain> Mime-Version: 1.0 (Apple Message framework v623) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: <91856a9e02132d2deb4368eee954c931@kernel.crashing.org> From: Segher Boessenkool Subject: Re: [PATCH 1/3] Add a new member name to structure irq_host Date: Wed, 1 Aug 2007 00:13:19 +0200 To: Benjamin Herrenschmidt Cc: linuxppc-dev@ozlabs.org, Chen Gong , paulus@samba.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , >>> Which makes me think (again) that we should have an optional >>> device_node >>> pointer in irq_host. I know you said you wanted the irq stuff to be >>> OF >>> agnostic, but the reality is most of the implementations do have an >>> OF >>> node. And all of the newer irq_host implementations do, with the >>> exception of PS3 and celleb - which are special. >> >> How do you suggest to get a reasonable display name out of >> the device tree? The recommended human-readable name for >> interrupt controller nodes is "interrupt-controller"... >> You cannot use "device_type" either, and using "compatible" >> requires selecting one of its string entries, and likely >> using a lookup table after that, too. > > In that case, I would display the node full path. Those tend to be quite long, in the cases where there are multiple interrupt controllers in the system; and really useless otherwise. I think the interrupt controllers should still just fill in the names "manually". It's a good thing to have an of_node in the irq_host struct anyway, though :-) Segher