From: Robin Murphy <robin.murphy@arm.com>
To: Christoph Hellwig <hch@lst.de>, iommu@lists.linux.dev
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Bingbu Cao <bingbu.cao@intel.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-s390@vger.kernel.org, sparclinux@vger.kernel.org,
linux-media@vger.kernel.org, virtualization@lists.linux.dev,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH] dma-mapping: clear mark DMA ops as an architecture feature
Date: Tue, 27 Aug 2024 13:31:59 +0100 [thread overview]
Message-ID: <91ef4036-6468-4ecc-ac14-0146130d8da4@arm.com> (raw)
In-Reply-To: <20240824035817.1163502-2-hch@lst.de>
On 24/08/2024 4:57 am, Christoph Hellwig wrote:
> DMA ops are a helper for architectures and not for drivers to override
> the DMA implementation. Unfortunately driver authors keep ignoring
> this. Make this more clear by renaming the symbol to ARCH_DMA_OPS,
> have the three drivers overriding it depend on that. They should
> probably also be marked broken, but we can give them a bit of a grace
> period for that.
Nit: from a quick survey of "git grep 'select ARCH_'", maybe
ARCH_HAS_DMA_OPS might be the clearest and most consistent name?
Otherwise, now that any potential confusion from drivers/iommu is no
more, I too thoroughly approve of the overall idea.
Acked-by: Robin Murphy <robin.murphy@arm.com>
next prev parent reply other threads:[~2024-08-27 13:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-24 3:57 clearly mark DMA_OPS support as an architecture feasture Christoph Hellwig
2024-08-24 3:57 ` [PATCH] dma-mapping: clear mark DMA ops as an architecture feature Christoph Hellwig
2024-08-24 7:58 ` Sakari Ailus
2024-08-25 11:33 ` Thomas Gleixner
2024-08-27 12:31 ` Robin Murphy [this message]
2024-08-26 6:16 ` clearly mark DMA_OPS support as an architecture feasture Jason Wang
2024-08-26 6:27 ` Jason Wang
2024-08-26 6:30 ` Christoph Hellwig
2024-08-26 6:32 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91ef4036-6468-4ecc-ac14-0146130d8da4@arm.com \
--to=robin.murphy@arm.com \
--cc=bingbu.cao@intel.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux.dev \
--cc=jasowang@redhat.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=m.szyprowski@samsung.com \
--cc=mst@redhat.com \
--cc=sakari.ailus@linux.intel.com \
--cc=sparclinux@vger.kernel.org \
--cc=virtualization@lists.linux.dev \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).