From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3tvQ131S4wzDqWF for ; Thu, 5 Jan 2017 22:09:10 +1100 (AEDT) Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id v05B8o2C054284 for ; Thu, 5 Jan 2017 06:09:09 -0500 Received: from e23smtp04.au.ibm.com (e23smtp04.au.ibm.com [202.81.31.146]) by mx0b-001b2d01.pphosted.com with ESMTP id 27skwvu8q5-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 05 Jan 2017 06:09:08 -0500 Received: from localhost by e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 5 Jan 2017 21:09:05 +1000 Received: from d23relay08.au.ibm.com (d23relay08.au.ibm.com [9.185.71.33]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 595042CE8046 for ; Thu, 5 Jan 2017 22:09:04 +1100 (EST) Received: from d23av06.au.ibm.com (d23av06.au.ibm.com [9.190.235.151]) by d23relay08.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v05B96Xp53608528 for ; Thu, 5 Jan 2017 22:09:06 +1100 Received: from d23av06.au.ibm.com (localhost [127.0.0.1]) by d23av06.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id v05B93tO008173 for ; Thu, 5 Jan 2017 22:09:04 +1100 Subject: Re: [PATCH] powerpc/perf: use is_kernel_addr macro in perf_get_misc_flags() To: Anshuman Khandual , mpe@ellerman.id.au References: <1482559549-22273-1-git-send-email-maddy@linux.vnet.ibm.com> <58609956.3040204@linux.vnet.ibm.com> Cc: linuxppc-dev@lists.ozlabs.org From: Madhavan Srinivasan Date: Thu, 5 Jan 2017 16:39:01 +0530 MIME-Version: 1.0 In-Reply-To: <58609956.3040204@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Message-Id: <92cebe39-8ad1-7d5f-0521-24cbdd4cccbb@linux.vnet.ibm.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Monday 26 December 2016 09:45 AM, Anshuman Khandual wrote: > On 12/24/2016 11:35 AM, Madhavan Srinivasan wrote: >> Cleanup to use is_kernel_addr macro. >> >> Signed-off-by: Madhavan Srinivasan >> --- >> arch/powerpc/perf/core-book3s.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/powerpc/perf/core-book3s.c b/arch/powerpc/perf/core-book3s.c >> index 2cdf2647cdb0..d9c74fd1b37b 100644 >> --- a/arch/powerpc/perf/core-book3s.c >> +++ b/arch/powerpc/perf/core-book3s.c >> @@ -243,7 +243,7 @@ static inline u32 perf_get_misc_flags(struct pt_regs *regs) >> */ >> if (ppmu->flags & PPMU_NO_SIPR) { >> unsigned long siar = mfspr(SPRN_SIAR); >> - if (siar >= PAGE_OFFSET) >> + if (is_kernel_addr(siar)) >> return PERF_RECORD_MISC_KERNEL; >> return PERF_RECORD_MISC_USER; >> } > While you are at this, why not also clean up these in the xmon code > as well. Yes. Have handled this in a separate patch. Maddy > arch/powerpc/xmon/xmon.c: if (sp < PAGE_OFFSET) { > arch/powerpc/xmon/xmon.c: if (lr < PAGE_OFFSET > arch/powerpc/xmon/xmon.c: } else if (lr >= PAGE_OFFSET > arch/powerpc/xmon/xmon.c: if (addr < PAGE_OFFSET)