linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Arun KS <arunks@codeaurora.org>
To: Joe Perches <joe@perches.com>
Cc: "Mike Snitzer" <snitzer@redhat.com>,
	"Kemi Wang" <kemi.wang@intel.com>,
	dri-devel@lists.freedesktop.org,
	"J. Bruce Fields" <bfields@fieldses.org>,
	linux-sctp@vger.kernel.org, "Paul Mackerras" <paulus@samba.org>,
	"Pavel Machek" <pavel@ucw.cz>, "Christoph Lameter" <cl@linux.com>,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	"David (ChunMing) Zhou" <David1.Zhou@amd.com>,
	"Petr Tesarik" <ptesarik@suse.com>,
	ceph-devel@vger.kernel.org,
	"James E.J. Bottomley" <jejb@parisc-linux.org>,
	kasan-dev@googlegroups.com,
	"Marcos Paulo de Souza" <marcos.souza.org@gmail.com>,
	"Steven J. Hill" <steven.hill@cavium.com>,
	"David Rientjes" <rientjes@google.com>,
	"Anthony Yznaga" <anthony.yznaga@oracle.com>,
	"Daniel Vacek" <neelx@redhat.com>, "Roman Gushchin" <guro@fb.com>,
	"Len Brown" <len.brown@intel.com>,
	linux-pm@vger.kernel.org, "Vlastimil Babka" <vbabka@suse.cz>,
	linux-um@lists.infradead.org,
	"Mike Rapoport" <rppt@linux.vnet.ibm.com>,
	"Alexander Viro" <viro@zeniv.linux.org.uk>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Trond Myklebust" <trond.myklebust@hammerspace.com>,
	"Anton Altaparmakov" <anton@tuxera.com>,
	linux-parisc@vger.kernel.org,
	"Mathieu Malaterre" <malat@debian.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	linux-kernel@vger.kernel.org, "Cyril Bur" <cyrilbur@gmail.com>,
	"Arve Hjønnevåg" <arve@android.com>,
	netfilter-devel@vger.kernel.org,
	"Souptick Joarder" <jrdr.linux@gmail.com>,
	"Dmitry Kasatkin" <dmitry.kasatkin@gmail.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Andrew-CT Chen" <andrew-ct.chen@mediatek.com>,
	"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
	"David Airlie" <airlied@linux.ie>,
	dm-devel@redhat.com, "Nadav Amit" <namit@vmware.com>,
	"Omar Sandoval" <osandov@fb.com>,
	"Alasdair Kergon" <agk@redhat.com>,
	linux-s390@vger.kernel.org,
	"Stephen Hemminger" <sthemmin@microsoft.com>,
	intel-gfx@lists.freedesktop.org, "Helge Deller" <deller@gmx.de>,
	"Hugh Dickins" <hughd@google.com>,
	"Luis R. Rodriguez" <mcgrof@kernel.org>,
	coreteam@netfilter.org,
	"Jozsef Kadlecsik" <kadlec@blackhole.kfki.hu>,
	"Andrey Ryabinin" <aryabinin@virtuozzo.com>,
	linux-media@vger.kernel.org, YueHaibing <yuehaibing@huawei.com>,
	"Todd Kjos" <tkjos@android.com>,
	"Philippe Ombredanne" <pombredanne@nexb.com>,
	"Jani Nikula" <jani.nikula@linux.intel.com>,
	"Jia He" <jia.he@hxt-semitech.com>, "Tejun Heo" <tj@kernel.org>,
	"Shakeel Butt" <shakeelb@google.com>,
	"Houlong Wei" <houlong.wei@mediatek.com>,
	"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
	"Martijn Coenen" <maco@android.com>,
	linux-arm-kernel@lists.infradead.org,
	"Khalid Aziz" <khalid@gonehiking.org>,
	"Oded Gabbay" <oded.gabbay@gmail.com>,
	linaro-mm-sig@lists.linaro.org,
	linux-ntfs-dev@lists.sourceforge.net,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Florian Westphal" <fw@strlen.de>,
	"Anna Schumaker" <anna.schumaker@netapp.com>,
	"Pekka Enberg" <penberg@kernel.org>,
	"Minchan Kim" <minchan@kernel.org>,
	"Eric Biederman" <ebiederm@xmission.com>,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
	"Martin Schwidefsky" <schwidefsky@de.ibm.com>,
	"Joonsoo Kim" <iamjoonsoo.kim@lge.com>,
	"Kate Stewart" <kstewart@linuxfoundation.org>,
	"Marcelo Ricardo Leitner" <marcelo.leitner@gmail.com>,
	linux-fsdevel@vger.kernel.org,
	"Tetsuo Handa" <penguin-kernel@i-love.sakura.ne.jp>,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
	"Heiko Carstens" <heiko.carstens@de.ibm.com>,
	"Stefan Agner" <stefan@agner.ch>,
	"James Morris" <jmorris@namei.org>,
	netdev@vger.kernel.org, amd-gfx@lists.freedesktop.org,
	"Jan Kara" <jack@suse.cz>,
	"Alexander Duyck" <alexander.h.duyck@linux.intel.com>,
	"Gerrit Renker" <gerrit@erg.abdn.ac.uk>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Miklos Szeredi" <miklos@szeredi.hu>,
	"David Hildenbrand" <david@redhat.com>,
	"Matthew Wilcox" <willy@infradead.org>,
	"Konstantin Khlebnikov" <khlebnikov@yandex-team.ru>,
	"Matthew Auld" <matthew.auld@intel.com>,
	"Guo Ren" <ren_guo@c-sky.com>,
	"Huang Ying" <ying.huang@intel.com>,
	"Alexey Kuznetsov" <kuznet@ms2.inr.ac.ru>,
	"Ilya Dryomov" <idryomov@gmail.com>,
	"Alexey Dobriyan" <adobriyan@gmail.com>,
	"Pablo Neira Ayuso" <pablo@netfilter.org>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	"Kees Cook" <keescook@chromium.org>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Haiyang Zhang" <haiyangz@microsoft.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Borislav Petkov" <bp@alien8.de>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"Dan Williams" <dan.j.williams@intel.com>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Dan Streetman" <ddstreet@ieee.org>,
	"Oscar Salvador" <osalvador@suse.de>,
	linux-nfs@vger.kernel.org, "Neil Horman" <nhorman@tuxdriver.com>,
	"Tvrtko Ursulin" <tvrtko.ursulin@intel.com>,
	"Jeff Layton" <jlayton@kernel.org>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jessica Yu" <jeyu@kernel.org>,
	devel@linuxdriverproject.org,
	"David S. Miller" <davem@davemloft.net>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	"Michal Hocko" <mhocko@suse.com>,
	"Minghsiu Tsai" <minghsiu.tsai@mediatek.com>,
	"Christian König" <christian.koenig@amd.com>,
	"VMware,  Inc." <pv-drivers@vmware.com>,
	"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
	"Chris Wilson" <chris@chris-wilson.co.uk>,
	linux-mm@kvack.org, "Alexander Potapenko" <glider@google.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	getarunks@gmail.com, "Chintan Pandya" <cpandya@codeaurora.org>,
	devel@driverdev.osuosl.org, "Yan, Zheng" <zyan@redhat.com>,
	xen-devel@lists.xenproject.org, "Sage Weil" <sage@redhat.com>,
	dccp@vger.kernel.org, "Richard Weinberger" <richard@nod.at>,
	"Seth Jennings" <sjenning@redhat.com>,
	x86@kernel.org, "Ingo Molnar" <mingo@redhat.com>,
	"Laura Abbott" <labbott@redhat.com>,
	"Mimi Zohar" <zohar@linux.vnet.ibm.com>,
	"Jeff Dike" <jdike@addtoit.com>,
	"Pavel Tatashin" <pavel.tatashin@microsoft.com>,
	"Jann Horn" <jannh@google.com>,
	"Xavier Deguillard" <xdeguillard@vmware.com>,
	"Johannes Weiner" <hannes@cmpxchg.org>,
	"Jérôme Glisse" <jglisse@redhat.com>,
	"Kirill Tkhai" <ktkhai@virtuozzo.com>,
	linux-mediatek@lists.infradead.org,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Tiffany Lin" <tiffany.lin@mediatek.com>,
	linux-integrity@vger.kernel.org,
	"Dmitry Vyukov" <dvyukov@google.com>,
	"Juergen Gross" <jgross@suse.com>,
	"Yang Shi" <yang.shi@linux.alibaba.com>,
	"Hideaki YOSHIFUJI" <yoshfuji@linux-ipv6.org>,
	linuxppc-dev@lists.ozlabs.org,
	"Vlad Yasevich" <vyasevich@gmail.com>,
	linux-decnet-user@lists.sourceforge.net,
	kexec@lists.infradead.org, linux-security-module@vger.kernel.org,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Mika Kuoppala" <mika.kuoppala@linux.intel.com>,
	"Mel Gorman" <mgorman@techsingularity.net>
Subject: Re: [PATCH] mm: convert totalram_pages, totalhigh_pages and managed_pages to atomic.
Date: Tue, 23 Oct 2018 10:18:26 +0530	[thread overview]
Message-ID: <92d3523427e45124c71e16baabceb8c5@codeaurora.org> (raw)
In-Reply-To: <c57bcc584b3700c483b0311881ec3ae8786f88b1.camel@perches.com>

On 2018-10-23 09:45, Joe Perches wrote:
> On Mon, 2018-10-22 at 22:53 +0530, Arun KS wrote:
>> Remove managed_page_count_lock spinlock and instead use atomic
>> variables.
> 

Hello Joe,
> Perhaps better to define and use macros for the accesses
> instead of specific uses of atomic_long_<inc/dec/read>
> 
> Something like:
> 
> #define totalram_pages()	(unsigned 
> long)atomic_long_read(&_totalram_pages)
> #define totalram_pages_inc()	(unsigned 
> long)atomic_long_inc(&_totalram_pages)
> #define totalram_pages_dec()	(unsigned 
> long)atomic_long_dec(&_totalram_pages)

That sounds like a nice idea.

Regards,
Arun

  reply	other threads:[~2018-10-23 11:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-22 17:23 [PATCH] mm: convert totalram_pages, totalhigh_pages and managed_pages to atomic Arun KS
2018-10-22 18:11 ` Michal Hocko
2018-10-23  4:46   ` Arun Sudhilal
2018-10-23  4:15 ` Joe Perches
2018-10-23  4:48   ` Arun KS [this message]
2018-10-23  5:37 ` Huang, Ying
2018-11-22  1:33 ` Guo Ren
2018-11-22  1:33   ` Guo Ren
2018-11-22 20:01 ` Kuehling, Felix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=92d3523427e45124c71e16baabceb8c5@codeaurora.org \
    --to=arunks@codeaurora.org \
    --cc=David1.Zhou@amd.com \
    --cc=adobriyan@gmail.com \
    --cc=agk@redhat.com \
    --cc=airlied@linux.ie \
    --cc=akpm@linux-foundation.org \
    --cc=alexander.deucher@amd.com \
    --cc=alexander.h.duyck@linux.intel.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=andrew-ct.chen@mediatek.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=anna.schumaker@netapp.com \
    --cc=anthony.yznaga@oracle.com \
    --cc=anton@tuxera.com \
    --cc=arnd@arndb.de \
    --cc=arve@android.com \
    --cc=aryabinin@virtuozzo.com \
    --cc=bfields@fieldses.org \
    --cc=bigeasy@linutronix.de \
    --cc=boris.ostrovsky@oracle.com \
    --cc=bp@alien8.de \
    --cc=broonie@kernel.org \
    --cc=ceph-devel@vger.kernel.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=christian.koenig@amd.com \
    --cc=cl@linux.com \
    --cc=corbet@lwn.net \
    --cc=coreteam@netfilter.org \
    --cc=cpandya@codeaurora.org \
    --cc=cyrilbur@gmail.com \
    --cc=dan.j.williams@intel.com \
    --cc=davem@davemloft.net \
    --cc=david@redhat.com \
    --cc=dccp@vger.kernel.org \
    --cc=ddstreet@ieee.org \
    --cc=deller@gmx.de \
    --cc=devel@driverdev.osuosl.org \
    --cc=devel@linuxdriverproject.org \
    --cc=dm-devel@redhat.com \
    --cc=dmitry.kasatkin@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=dvyukov@google.com \
    --cc=ebiederm@xmission.com \
    --cc=edumazet@google.com \
    --cc=fw@strlen.de \
    --cc=gerrit@erg.abdn.ac.uk \
    --cc=getarunks@gmail.com \
    --cc=glider@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=guro@fb.com \
    --cc=gustavo@embeddedor.com \
    --cc=haiyangz@microsoft.com \
    --cc=hannes@cmpxchg.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=houlong.wei@mediatek.com \
    --cc=hpa@zytor.com \
    --cc=hughd@google.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=idryomov@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jack@suse.cz \
    --cc=jani.nikula@linux.intel.com \
    --cc=jannh@google.com \
    --cc=jdike@addtoit.com \
    --cc=jejb@parisc-linux.org \
    --cc=jeyu@kernel.org \
    --cc=jglisse@redhat.com \
    --cc=jgross@suse.com \
    --cc=jia.he@hxt-semitech.com \
    --cc=jlayton@kernel.org \
    --cc=jmorris@namei.org \
    --cc=joe@perches.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=jrdr.linux@gmail.com \
    --cc=kadlec@blackhole.kfki.hu \
    --cc=kasan-dev@googlegroups.com \
    --cc=keescook@chromium.org \
    --cc=kemi.wang@intel.com \
    --cc=kexec@lists.infradead.org \
    --cc=khalid@gonehiking.org \
    --cc=khlebnikov@yandex-team.ru \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=kstewart@linuxfoundation.org \
    --cc=ktkhai@virtuozzo.com \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=kys@microsoft.com \
    --cc=labbott@redhat.com \
    --cc=len.brown@intel.com \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-decnet-user@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-ntfs-dev@lists.sourceforge.net \
    --cc=linux-parisc@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-sctp@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=linux-um@lists.infradead.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maco@android.com \
    --cc=malat@debian.org \
    --cc=marcelo.leitner@gmail.com \
    --cc=marcos.souza.org@gmail.com \
    --cc=matthew.auld@intel.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mcgrof@kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mgorman@techsingularity.net \
    --cc=mhocko@suse.com \
    --cc=mika.kuoppala@linux.intel.com \
    --cc=miklos@szeredi.hu \
    --cc=minchan@kernel.org \
    --cc=minghsiu.tsai@mediatek.com \
    --cc=mingo@redhat.com \
    --cc=namit@vmware.com \
    --cc=neelx@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=oded.gabbay@gmail.com \
    --cc=osalvador@suse.de \
    --cc=osandov@fb.com \
    --cc=pablo@netfilter.org \
    --cc=paulus@samba.org \
    --cc=pavel.tatashin@microsoft.com \
    --cc=pavel@ucw.cz \
    --cc=penberg@kernel.org \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=pombredanne@nexb.com \
    --cc=ptesarik@suse.com \
    --cc=pv-drivers@vmware.com \
    --cc=rdunlap@infradead.org \
    --cc=ren_guo@c-sky.com \
    --cc=richard@nod.at \
    --cc=rientjes@google.com \
    --cc=rjw@rjwysocki.net \
    --cc=rodrigo.vivi@intel.com \
    --cc=rppt@linux.vnet.ibm.com \
    --cc=sage@redhat.com \
    --cc=schwidefsky@de.ibm.com \
    --cc=serge@hallyn.com \
    --cc=shakeelb@google.com \
    --cc=sjenning@redhat.com \
    --cc=snitzer@redhat.com \
    --cc=stefan@agner.ch \
    --cc=steven.hill@cavium.com \
    --cc=sthemmin@microsoft.com \
    --cc=sumit.semwal@linaro.org \
    --cc=tglx@linutronix.de \
    --cc=tiffany.lin@mediatek.com \
    --cc=tj@kernel.org \
    --cc=tkjos@android.com \
    --cc=trond.myklebust@hammerspace.com \
    --cc=tvrtko.ursulin@intel.com \
    --cc=tzimmermann@suse.de \
    --cc=vbabka@suse.cz \
    --cc=viro@zeniv.linux.org.uk \
    --cc=vyasevich@gmail.com \
    --cc=willy@infradead.org \
    --cc=x86@kernel.org \
    --cc=xdeguillard@vmware.com \
    --cc=xen-devel@lists.xenproject.org \
    --cc=yang.shi@linux.alibaba.com \
    --cc=ying.huang@intel.com \
    --cc=yoshfuji@linux-ipv6.org \
    --cc=yuehaibing@huawei.com \
    --cc=zohar@linux.vnet.ibm.com \
    --cc=zyan@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).