From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FB62C46475 for ; Tue, 23 Oct 2018 11:02:19 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 91EAD20665 for ; Tue, 23 Oct 2018 11:02:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="Yzp4Avzm"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="bYaIm7G2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 91EAD20665 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 42fVpJ3jjvzF37r for ; Tue, 23 Oct 2018 22:02:16 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=codeaurora.org header.i=@codeaurora.org header.b="Yzp4Avzm"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="bYaIm7G2"; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=codeaurora.org (client-ip=198.145.29.96; helo=smtp.codeaurora.org; envelope-from=arunks@codeaurora.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=codeaurora.org header.i=@codeaurora.org header.b="Yzp4Avzm"; dkim=pass (1024-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="bYaIm7G2"; dkim-atps=neutral Received: from smtp.codeaurora.org (smtp.codeaurora.org [198.145.29.96]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 42fS9r0w46zDsFP for ; Tue, 23 Oct 2018 20:03:59 +1100 (AEDT) Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 12E4D613FC; Tue, 23 Oct 2018 04:48:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1540270116; bh=dtzAW1nZDtsAh1MSgdkacD9E0lJhfSZAkRN995N8TJs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Yzp4AvzmfxApod3AvVMRM9/VSvwtME16rSo6QmUummsmDMZ5JXUdFRnR/pn1cfwpP wXb1CATSCl8d3P5BXWuyMnQRVMC5aPsoSybu1NLTHZEUJJajEwG4bNAvSUAJ09tocW SfWRULiwCiyYC7gxhEFdbw0zFt1VaExM86o6Z6h0= Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id 0DF6860C5F; Tue, 23 Oct 2018 04:48:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1540270107; bh=dtzAW1nZDtsAh1MSgdkacD9E0lJhfSZAkRN995N8TJs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bYaIm7G2OcCCJDBLW816Q8kMAVBokurTBwfOwmr1X/S16VklSCI+ZgBE1vofXkvlS /QTiMltOO8jrM0JrbIvtHC1ak5np5htf4+Hwn33cUITjbMSUQs/8eYtsTDeby1TC9C JRCmlPL55Lt442tTy1LcTmJ9LW9Y5VccKI1oH15k= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 23 Oct 2018 10:18:26 +0530 From: Arun KS To: Joe Perches Subject: Re: [PATCH] mm: convert totalram_pages, totalhigh_pages and managed_pages to atomic. In-Reply-To: References: <1540229092-25207-1-git-send-email-arunks@codeaurora.org> Message-ID: <92d3523427e45124c71e16baabceb8c5@codeaurora.org> X-Sender: arunks@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 X-Mailman-Approved-At: Tue, 23 Oct 2018 21:48:35 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mike Snitzer , Kemi Wang , dri-devel@lists.freedesktop.org, "J. Bruce Fields" , linux-sctp@vger.kernel.org, Paul Mackerras , Pavel Machek , Christoph Lameter , "K. Y. Srinivasan" , Sumit Semwal , "David \(ChunMing\) Zhou" , Petr Tesarik , ceph-devel@vger.kernel.org, "James E.J. Bottomley" , kasan-dev@googlegroups.com, Marcos Paulo de Souza , "Steven J. Hill" , David Rientjes , Anthony Yznaga , Daniel Vacek , Roman Gushchin , Len Brown , linux-pm@vger.kernel.org, Vlastimil Babka , linux-um@lists.infradead.org, Mike Rapoport , Alexander Viro , Thomas Gleixner , Trond Myklebust , Anton Altaparmakov , linux-parisc@vger.kernel.org, Mathieu Malaterre , Greg Kroah-Hartman , Randy Dunlap , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Cyril Bur , =?UTF-8?Q?Arve_Hj=C3=B8nnev=C3=A5g?= , netfilter-devel@vger.kernel.org, Souptick Joarder , Dmitry Kasatkin , Alex Deucher , Andrew Morton , Andrew-CT Chen , "Gustavo A. R. Silva" , David Airlie , dm-devel@redhat.com, Nadav Amit , Omar Sandoval , Alasdair Kergon , linux-s390@vger.kernel.org, Stephen Hemminger , intel-gfx@lists.freedesktop.org, Helge Deller , Hugh Dickins , "Luis R. Rodriguez" , coreteam@netfilter.org, Jozsef Kadlecsik , Andrey Ryabinin , linux-media@vger.kernel.org, YueHaibing , Todd Kjos , Philippe Ombredanne , Jani Nikula , Jia He , Tejun Heo , Shakeel Butt , Houlong Wei , Boris Ostrovsky , Martijn Coenen , linux-arm-kernel@lists.infradead.org, Khalid Aziz , Oded Gabbay , linaro-mm-sig@lists.linaro.org, linux-ntfs-dev@lists.sourceforge.net, Jonathan Corbet , Florian Westphal , Anna Schumaker , Pekka Enberg , Minchan Kim , Eric Biederman , "Aneesh Kumar K.V" , Martin Schwidefsky , Joonsoo Kim , Kate Stewart , Marcelo Ricardo Leitner , linux-fsdevel@vger.kernel.org, Tetsuo Handa , Joonas Lahtinen , Heiko Carstens , Stefan Agner , James Morris , netdev@vger.kernel.org, amd-gfx@lists.freedesktop.org, Jan Kara , Alexander Duyck , Gerrit Renker , Andy Shevchenko , Miklos Szeredi , David Hildenbrand , Matthew Wilcox , Konstantin Khlebnikov , Matthew Auld , Guo Ren , Huang Ying , Alexey Kuznetsov , Ilya Dryomov , Alexey Dobriyan , Pablo Neira Ayuso , "Serge E. Hallyn" , Kees Cook , Arnd Bergmann , Haiyang Zhang , Mark Brown , Borislav Petkov , Rodrigo Vivi , Dan Williams , Mauro Carvalho Chehab , Dan Streetman , Oscar Salvador , linux-nfs@vger.kernel.org, Neil Horman , Tvrtko Ursulin , Jeff Layton , Eric Dumazet , Jessica Yu , devel@linuxdriverproject.org, "David S. Miller" , "Kirill A. Shutemov" , Michal Hocko , Minghsiu Tsai , =?UTF-8?Q?Christian_K=C3=B6nig?= , "VMware, Inc." , Sebastian Andrzej Siewior , Chris Wilson , linux-mm@kvack.org, Alexander Potapenko , "H. Peter Anvin" , getarunks@gmail.com, Chintan Pandya , devel@driverdev.osuosl.org, "Yan, Zheng" , xen-devel@lists.xenproject.org, Sage Weil , dccp@vger.kernel.org, Richard Weinberger , Seth Jennings , x86@kernel.org, Ingo Molnar , Laura Abbott , Mimi Zohar , Jeff Dike , Pavel Tatashin , Jann Horn , Xavier Deguillard , Johannes Weiner , =?UTF-8?Q?J=C3=A9r?= =?UTF-8?Q?=C3=B4me_Glisse?= , Kirill Tkhai , linux-mediatek@lists.infradead.org, Matthias Brugger , Tiffany Lin , linux-integrity@vger.kernel.org, Dmitry Vyukov , Juergen Gross , Yang Shi , Hideaki YOSHIFUJI , linuxppc-dev@lists.ozlabs.org, Vlad Yasevich , linux-decnet-user@lists.sourceforge.net, kexec@lists.infradead.org, linux-security-module@vger.kernel.org, Thomas Zimmermann , Mika Kuoppala , Mel Gorman Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 2018-10-23 09:45, Joe Perches wrote: > On Mon, 2018-10-22 at 22:53 +0530, Arun KS wrote: >> Remove managed_page_count_lock spinlock and instead use atomic >> variables. > Hello Joe, > Perhaps better to define and use macros for the accesses > instead of specific uses of atomic_long_ > > Something like: > > #define totalram_pages() (unsigned > long)atomic_long_read(&_totalram_pages) > #define totalram_pages_inc() (unsigned > long)atomic_long_inc(&_totalram_pages) > #define totalram_pages_dec() (unsigned > long)atomic_long_dec(&_totalram_pages) That sounds like a nice idea. Regards, Arun