From: Tyrel Datwyler <tyreld@linux.ibm.com>
To: Jing Xiangfeng <jingxiangfeng@huawei.com>,
mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org,
jejb@linux.ibm.com, martin.petersen@oracle.com
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: ibmvfc: Fix error return in ibmvfc_probe()
Date: Wed, 9 Sep 2020 12:20:54 -0700 [thread overview]
Message-ID: <93fb2dbf-b386-4009-95e2-508c56c68607@linux.ibm.com> (raw)
In-Reply-To: <20200907083949.154251-1-jingxiangfeng@huawei.com>
On 9/7/20 1:39 AM, Jing Xiangfeng wrote:
> Fix to return error code PTR_ERR() from the error handling case instead
> of 0.
>
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
Acked-by: Tyrel Datwyler <tyreld@linux.ibm.com>
> ---
> drivers/scsi/ibmvscsi/ibmvfc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
> index ea7c8930592d..70daa0605082 100644
> --- a/drivers/scsi/ibmvscsi/ibmvfc.c
> +++ b/drivers/scsi/ibmvscsi/ibmvfc.c
> @@ -4928,6 +4928,7 @@ static int ibmvfc_probe(struct vio_dev *vdev, const struct vio_device_id *id)
> if (IS_ERR(vhost->work_thread)) {
> dev_err(dev, "Couldn't create kernel thread: %ld\n",
> PTR_ERR(vhost->work_thread));
> + rc = PTR_ERR(vhost->work_thread);
> goto free_host_mem;
> }
>
>
next prev parent reply other threads:[~2020-09-09 19:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 8:39 [PATCH] scsi: ibmvfc: Fix error return in ibmvfc_probe() Jing Xiangfeng
2020-09-09 19:20 ` Tyrel Datwyler [this message]
2020-09-10 2:11 ` Martin K. Petersen
2020-09-15 20:16 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93fb2dbf-b386-4009-95e2-508c56c68607@linux.ibm.com \
--to=tyreld@linux.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=jejb@linux.ibm.com \
--cc=jingxiangfeng@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=martin.petersen@oracle.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox