Re: [PATCH 2/2] scsi/cxlflash: Deprecate driver

[Frederic Barrat <fbarrat@linux.ibm.com>]

On 10/12/2024 06:40, Andrew Donnellan wrote:
> We intend to remove the cxlflash driver in an upcoming release. It is
> already marked as Obsolete in MAINTAINERS.
> 
> The cxlflash driver has received minimal maintenance for some time, and
> the CAPI Flash hardware that uses it is no longer commercially available.
> 
> Add a warning message on probe and change Kconfig to label the driver as
> deprecated and not build the driver by default.
> 
> Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com>


Reviewed-by: Frederic Barrat <fbarrat@linux.ibm.com>

   Fred

> ---
>   drivers/scsi/cxlflash/Kconfig | 6 ++++--
>   drivers/scsi/cxlflash/main.c  | 2 ++
>   2 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/cxlflash/Kconfig b/drivers/scsi/cxlflash/Kconfig
> index 5533bdcb0458..c424d36e89a6 100644
> --- a/drivers/scsi/cxlflash/Kconfig
> +++ b/drivers/scsi/cxlflash/Kconfig
> @@ -4,10 +4,12 @@
>   #
>   
>   config CXLFLASH
> -	tristate "Support for IBM CAPI Flash"
> +	tristate "Support for IBM CAPI Flash (DEPRECATED)"
>   	depends on PCI && SCSI && (CXL || OCXL) && EEH
>   	select IRQ_POLL
> -	default m
>   	help
> +	  The cxlflash driver is deprecated and will be removed in a future
> +	  kernel release.
> +
>   	  Allows CAPI Accelerated IO to Flash
>   	  If unsure, say N.
> diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c
> index 60d62b93d624..62806f5e32e6 100644
> --- a/drivers/scsi/cxlflash/main.c
> +++ b/drivers/scsi/cxlflash/main.c
> @@ -3651,6 +3651,8 @@ static int cxlflash_probe(struct pci_dev *pdev,
>   	int rc = 0;
>   	int k;
>   
> +	dev_err_once(&pdev->dev, "DEPRECATION: cxlflash is deprecated and will be removed in a future kernel release\n");
> +
>   	dev_dbg(&pdev->dev, "%s: Found CXLFLASH with IRQ: %d\n",
>   		__func__, pdev->irq);
>