From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 40j78g2SqtzF2GK for ; Fri, 11 May 2018 21:26:43 +1000 (AEST) Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w4BBOJiF040604 for ; Fri, 11 May 2018 07:26:40 -0400 Received: from e06smtp14.uk.ibm.com (e06smtp14.uk.ibm.com [195.75.94.110]) by mx0b-001b2d01.pphosted.com with ESMTP id 2hw95au045-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 11 May 2018 07:26:40 -0400 Received: from localhost by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 11 May 2018 12:26:39 +0100 Subject: Re: [PATCH v3 2/2] cxl: Report the tunneled operations status To: Philippe Bergheaud , linuxppc-dev@lists.ozlabs.org Cc: clombard@linux.ibm.com, benh@au1.ibm.com References: <20180425110834.16048-1-felix@linux.ibm.com> <20180425110834.16048-2-felix@linux.ibm.com> From: Frederic Barrat Date: Fri, 11 May 2018 13:26:36 +0200 MIME-Version: 1.0 In-Reply-To: <20180425110834.16048-2-felix@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Message-Id: <94ad5f45-5469-bb3c-23fd-62ea49528522@linux.ibm.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Le 25/04/2018 à 13:08, Philippe Bergheaud a écrit : > Failure to synchronize the tunneled operations does not prevent > the initialization of the cxl card. This patch reports the tunneled > operations status via /sys. > > Signed-off-by: Philippe Bergheaud > --- Good idea, but you'll have to also edit Documentation/ABI/testing/sysfs-class-cxl to describe the new sysfs entry. Fred > v3: Added this patch to report the tunneled operations status. > --- > drivers/misc/cxl/cxl.h | 1 + > drivers/misc/cxl/pci.c | 7 ++++++- > drivers/misc/cxl/sysfs.c | 10 ++++++++++ > 3 files changed, 17 insertions(+), 1 deletion(-) > > diff --git a/drivers/misc/cxl/cxl.h b/drivers/misc/cxl/cxl.h > index a4c9c8297a6d..918d4fb742d1 100644 > --- a/drivers/misc/cxl/cxl.h > +++ b/drivers/misc/cxl/cxl.h > @@ -717,6 +717,7 @@ struct cxl { > bool perst_select_user; > bool perst_same_image; > bool psl_timebase_synced; > + bool tunneled_ops_supported; > > /* > * number of contexts mapped on to this card. Possible values are: > diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c > index 355c789406f7..008f50a0c465 100644 > --- a/drivers/misc/cxl/pci.c > +++ b/drivers/misc/cxl/pci.c > @@ -1742,9 +1742,14 @@ static int cxl_configure_adapter(struct cxl *adapter, struct pci_dev *dev) > /* Required for devices using CAPP DMA mode, harmless for others */ > pci_set_master(dev); > > - if (cxl_is_power9()) > + adapter->tunneled_ops_supported = false; > + > + if (cxl_is_power9()) { > if (pnv_pci_set_tunnel_bar(dev, 0x00020000E0000000ull, 1)) > dev_info(&dev->dev, "Tunneled operations unsupported\n"); > + else > + adapter->tunneled_ops_supported = true; > + } > > if ((rc = pnv_phb_to_cxl_mode(dev, adapter->native->sl_ops->capi_mode))) > goto err; > diff --git a/drivers/misc/cxl/sysfs.c b/drivers/misc/cxl/sysfs.c > index 95285b7f636f..4b5a4c5d3c01 100644 > --- a/drivers/misc/cxl/sysfs.c > +++ b/drivers/misc/cxl/sysfs.c > @@ -78,6 +78,15 @@ static ssize_t psl_timebase_synced_show(struct device *device, > return scnprintf(buf, PAGE_SIZE, "%i\n", adapter->psl_timebase_synced); > } > > +static ssize_t tunneled_ops_supported_show(struct device *device, > + struct device_attribute *attr, > + char *buf) > +{ > + struct cxl *adapter = to_cxl_adapter(device); > + > + return scnprintf(buf, PAGE_SIZE, "%i\n", adapter->tunneled_ops_supported); > +} > + > static ssize_t reset_adapter_store(struct device *device, > struct device_attribute *attr, > const char *buf, size_t count) > @@ -183,6 +192,7 @@ static struct device_attribute adapter_attrs[] = { > __ATTR_RO(base_image), > __ATTR_RO(image_loaded), > __ATTR_RO(psl_timebase_synced), > + __ATTR_RO(tunneled_ops_supported), > __ATTR_RW(load_image_on_perst), > __ATTR_RW(perst_reloads_same_image), > __ATTR(reset, S_IWUSR, NULL, reset_adapter_store), >