From: Andrew Donnellan <ajd@linux.ibm.com>
To: Kunwu Chan <chentao@kylinos.cn>,
fbarrat@linux.ibm.com, arnd@arndb.de, mpe@ellerman.id.au,
mrochs@linux.vnet.ibm.com
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Kunwu Chan <kunwu.chan@hotmail.com>
Subject: Re: [PATCH v2] cxl: Fix null pointer dereference in cxl_get_fd
Date: Mon, 15 Jan 2024 16:02:51 +1100 [thread overview]
Message-ID: <94f35d3f8ad3b8052100594bf78e915beb477a47.camel@linux.ibm.com> (raw)
In-Reply-To: <20240112054903.133145-1-chentao@kylinos.cn>
On Fri, 2024-01-12 at 13:49 +0800, Kunwu Chan wrote:
> +err:
> + if (rc < 0)
> + return ERR_PTR(rc);
> return NULL;
I don't think there's a way for this NULL to ever get returned?
Apart from that it looks good:
Reviewed-by: Andrew Donnellan <ajd@linux.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
ajd@linux.ibm.com IBM Australia Limited
next prev parent reply other threads:[~2024-01-15 5:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 5:49 [PATCH v2] cxl: Fix null pointer dereference in cxl_get_fd Kunwu Chan
2024-01-15 5:02 ` Andrew Donnellan [this message]
2024-01-15 11:05 ` Frederic Barrat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94f35d3f8ad3b8052100594bf78e915beb477a47.camel@linux.ibm.com \
--to=ajd@linux.ibm.com \
--cc=arnd@arndb.de \
--cc=chentao@kylinos.cn \
--cc=fbarrat@linux.ibm.com \
--cc=kunwu.chan@hotmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=mrochs@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).