From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C2DDC43331 for ; Tue, 12 Nov 2019 18:54:14 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B195321783 for ; Tue, 12 Nov 2019 18:54:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Kgu/GllJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B195321783 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47CH3725VWzF34f for ; Wed, 13 Nov 2019 05:54:11 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::541; helo=mail-pg1-x541.google.com; envelope-from=eric.dumazet@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Kgu/GllJ"; dkim-atps=neutral Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47CGDw2C3YzF5X1 for ; Wed, 13 Nov 2019 05:17:36 +1100 (AEDT) Received: by mail-pg1-x541.google.com with SMTP id w11so12351061pga.12 for ; Tue, 12 Nov 2019 10:17:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6u8AuSwwEE+YzGjQ7qfJp6neppsuNi6MySBbeF4/IPk=; b=Kgu/GllJJW+hHZrChI1erjsLqLhM4zsC5sx0iwwMF+a9Jzy9LOjqpJcgsPpm7LV7E+ 5lhtCGSYnmaXdzaOdhr2dPsDec+bP2GsFoL76MoBDQ1cdGhDTHFhQz8Zj4JKg5L6lRUS cn441jUZWJCGSOMKxb3lajAPyNZX2lTGt8gIJyQWahOTPWJmEWHffqJlotB6PnW7XoAW 58jz2Yio7zzqtuPFzbmS1qRf6eXYdzAno4LyzZ7dmYhEBnieUj0N5V+jXau3h9mIedp+ OVjwUNh0OPhCMfcbBqg/mUB+mR/FuloVxjzzBJ1XmvWkqBPQTVyKZv8Gc32hh+Pvujip qEYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6u8AuSwwEE+YzGjQ7qfJp6neppsuNi6MySBbeF4/IPk=; b=pmRz7Vu2daNXBoTHTvP6sSfmaHfMi1aSKq+P2/1sq8+E5gZ3ebpOJv2w9laua8k88K vUMFZxODkckRO37SzM10DmvSVK90Jw4F96blGeHBfaOpkLWs6AIUYdG83Z6wqq0GUKLR eztFark5fCOFZPppD/5QrVCKk9NLVcFql06Qymd8EVtu5Jr7x/w9fxmy5S/VViV5BztP go40GHiLBPgJpEpPU6tl6DU/eB5GADrgvpO/fO2nBDTyExsZhJNfzQ9Q++2dEQmxEy1w CcggPT+1RW82QE20FjOAstSk+rVnOiZ1j6CAmja85Jp7wNIER6fpqyC+29t6soipQ0wo HR0g== X-Gm-Message-State: APjAAAV89RlJTs3IG5vR2OvrKPAhTtyiZ4fJ9ngedFxJEelZWXyEiWzk M6F3UMojiRxfoGbzyxsKzls= X-Google-Smtp-Source: APXvYqwwSH0qDU9uj6WdYBx522qw+uctwzudp+uGOiDq9r/xUGj7tA3eafhCY2h5xpmPHLqI9MGhLA== X-Received: by 2002:a62:aa0d:: with SMTP id e13mr38879031pff.214.1573582651106; Tue, 12 Nov 2019 10:17:31 -0800 (PST) Received: from ?IPv6:2620:15c:2c1:200:55c7:81e6:c7d8:94b? ([2620:15c:2c1:200:55c7:81e6:c7d8:94b]) by smtp.gmail.com with ESMTPSA id 206sm10280425pfu.45.2019.11.12.10.17.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Nov 2019 10:17:30 -0800 (PST) Subject: Re: net-next branch fails to build on my P8 CI system To: Abdul Haleem , linuxppc-dev References: <1573538337.1382.3.camel@abdul> From: Eric Dumazet Message-ID: <951e74ff-07ef-faac-2a55-6dce8bd3d2d5@gmail.com> Date: Tue, 12 Nov 2019 10:17:28 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <1573538337.1382.3.camel@abdul> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev , David Miller , Eric Dumazet Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 11/11/19 9:58 PM, Abdul Haleem wrote: > Greeting's > > I see a build failure for net-next branch on my Power 8 system > > 13:25:10 ERROR| [stderr] ./include/linux/u64_stats_sync.h: In function 64_stats_read�: > 13:25:10 ERROR| [stderr] ./include/linux/u64_stats_sync.h:80:2: warning: passing argument 1 of 鈥榣ocal_read鈥� discards 鈥榗onst鈥� qualifier from pointer target type [enabled by default] > 13:25:10 ERROR| [stderr] return local64_read(&p->v); > 13:25:10 ERROR| [stderr] ^ > 13:25:10 ERROR| [stderr] In file included from ./include/asm-generic/local64.h:22:0, > 13:25:10 ERROR| [stderr] from ./arch/powerpc/include/generated/asm/local64.h:1, > 13:25:10 ERROR| [stderr] from ./include/linux/u64_stats_sync.h:72, > 13:25:10 ERROR| [stderr] from ./include/linux/cgroup-defs.h:20, > 13:25:10 ERROR| [stderr] from ./include/linux/cgroup.h:28, > 13:25:10 ERROR| [stderr] from ./include/linux/memcontrol.h:13, > 13:25:10 ERROR| [stderr] from ./include/linux/swap.h:9, > 13:25:10 ERROR| [stderr] from ./include/linux/suspend.h:5, > 13:25:10 ERROR| [stderr] from init/do_mounts.c:7: > 13:25:10 ERROR| [stderr] ./arch/powerpc/include/asm/local.h:20:24: note: expected 鈥榮truct local_t *鈥� but argument is of type 鈥榗onst struct local_t *鈥� > 13:25:10 ERROR| [stderr] static __inline__ long local_read(local_t *l) > 13:25:10 ERROR| [stderr] ^ > 13:25:11 ERROR| [stderr] In file included from ./include/linux/cgroup-defs.h:20:0, > 13:25:11 ERROR| [stderr] from ./include/linux/cgroup.h:28, > 13:25:11 ERROR| [stderr] from ./include/linux/hugetlb.h:9, > 13:25:11 ERROR| [stderr] from arch/powerpc/kvm/book3s_64_vio_hv.c:16: > 13:25:11 ERROR| [stderr] ./include/linux/u64_stats_sync.h: In function 鈥榰64_stats_read鈥�: > 13:25:11 ERROR| [stderr] ./include/linux/u64_stats_sync.h:80:2: error: passing argument 1 of 鈥榣ocal_read鈥� discards 鈥榗onst鈥� qualifier from pointer target type [-Werror] > 13:25:11 ERROR| [stderr] return local64_read(&p->v); > 13:25:11 ERROR| [stderr] ^ > > I see some recent code changes here > > 9dfd871481c8e9c512938e9ce632beed645363e0 Merge branch 'u64_stats_t' > fd2f4737870eb866537fbbffa2b59414b9b0c0a2 net: use u64_stats_t in struct > pcpu_lstats > 5260dd3ed1ff7eba39251b28977e4d8950e2f099 tun: switch to u64_stats_t > 316580b69d0a7aeeee5063af47438b626bc47cbd u64_stats: provide u64_stats_t > type > > Fix has been sent few days ago. For some reason the linuxppc-dev@lists.ozlabs.org list has not received the patch. >From 47c47befdcf31fb8498c9e630bb8e0dc3ef88079 Mon Sep 17 00:00:00 2001 From: Eric Dumazet Date: Fri, 8 Nov 2019 06:04:35 -0800 Subject: [PATCH] powerpc: add const qual to local_read() parameter A patch in net-next triggered a compile error on powerpc. This seems reasonable to relax powerpc local_read() requirements. Fixes: 316580b69d0a ("u64_stats: provide u64_stats_t type") Signed-off-by: Eric Dumazet Reported-by: kbuild test robot Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org --- arch/powerpc/include/asm/local.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/include/asm/local.h b/arch/powerpc/include/asm/local.h index fdd00939270bf08113b537a090d6a6e34a048361..bc4bd19b7fc235b80ec1132f44409b6fe1057975 100644 --- a/arch/powerpc/include/asm/local.h +++ b/arch/powerpc/include/asm/local.h @@ -17,7 +17,7 @@ typedef struct #define LOCAL_INIT(i) { (i) } -static __inline__ long local_read(local_t *l) +static __inline__ long local_read(const local_t *l) { return READ_ONCE(l->v); } -- 2.24.0.432.g9d3f5f5b63-goog