From: Jens Axboe <axboe@kernel.dk>
To: Al Viro <viro@ZenIV.linux.org.uk>, Christoph Hellwig <hch@lst.de>
Cc: Abdul Haleem <abdhalee@linux.vnet.ibm.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
linux-xfs <linux-xfs@vger.kernel.org>,
linux-next <linux-next@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
chandan <chandan@linux.vnet.ibm.com>
Subject: Re: [linux-next][XFS][trinity] WARNING: CPU: 32 PID: 31369 at fs/iomap.c:993
Date: Mon, 18 Sep 2017 09:51:29 -0600 [thread overview]
Message-ID: <955c9c41-1941-5cf4-751c-14a3efa9d0ce@kernel.dk> (raw)
In-Reply-To: <20170918154328.GA32076@ZenIV.linux.org.uk>
On 09/18/2017 09:43 AM, Al Viro wrote:
> On Mon, Sep 18, 2017 at 05:39:47PM +0200, Christoph Hellwig wrote:
>> On Mon, Sep 18, 2017 at 09:28:55AM -0600, Jens Axboe wrote:
>>> If it's expected, why don't we kill the WARN_ON_ONCE()? I get it all
>>> the time running xfstests as well.
>>
>> Dave insisted on it to decourage users/applications from mixing
>> mmap and direct I/O.
>>
>> In many ways a tracepoint might be the better way to diagnose these.
>
> sysctl suppressing those two, perhaps?
I'd rather just make it a trace point, but don't care too much.
The code doesn't even have a comment as to why that WARN_ON() is
there or expected. Seems pretty sloppy to me, not a great way
to "discourage" users to mix mmap/dio.
--
Jens Axboe
next prev parent reply other threads:[~2017-09-18 15:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 14:56 [linux-next][XFS][trinity] WARNING: CPU: 32 PID: 31369 at fs/iomap.c:993 Abdul Haleem
2017-09-18 15:27 ` Christoph Hellwig
2017-09-18 15:28 ` Jens Axboe
2017-09-18 15:39 ` Christoph Hellwig
2017-09-18 15:43 ` Al Viro
2017-09-18 15:51 ` Jens Axboe [this message]
2017-09-18 21:53 ` Dave Chinner
2017-09-18 21:31 ` Dave Chinner
2017-09-18 22:00 ` Eric Sandeen
2017-09-18 22:04 ` Darrick J. Wong
2017-09-18 22:05 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=955c9c41-1941-5cf4-751c-14a3efa9d0ce@kernel.dk \
--to=axboe@kernel.dk \
--cc=abdhalee@linux.vnet.ibm.com \
--cc=chandan@linux.vnet.ibm.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).