From: "Russell Currey" <ruscur@russell.cc>
To: "Andrew Donnellan" <ajd@linux.ibm.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Christophe Leroy" <christophe.leroy@c-s.fr>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Paul Mackerras" <paulus@samba.org>,
mikey@neuling.org
Cc: linuxppc-dev@lists.ozlabs.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 13/13] powerpc/ptrace: move ptrace_triggered() into hw_breakpoint.c
Date: Fri, 28 Feb 2020 15:02:14 +1100 [thread overview]
Message-ID: <95816cae-565b-40a8-a3bf-4733672c6e91@www.fastmail.com> (raw)
In-Reply-To: <b2b97a86-2f29-af14-52c2-a69ef6202b75@linux.ibm.com>
This was my fault, I should really test changes like these before they go live. Apologies for the confusion caused
--
Russell Currey
ruscur@russell.cc
On Fri, Feb 28, 2020, at 2:59 PM, Andrew Donnellan wrote:
> On 28/2/20 9:16 am, Michael Ellerman wrote:
> > Christophe Leroy <christophe.leroy@c-s.fr> writes:
> >> Russel,
> >>
> >> Le 27/02/2020 à 12:49, Christophe Leroy a écrit :
> >>> ptrace_triggered() is declared in asm/hw_breakpoint.h and
> >>> only needed when CONFIG_HW_BREAKPOINT is set, so move it
> >>> into hw_breakpoint.c
> >>
> >> My series v4 is definitely buggy (I included ptrace_decl.h instead
> >> instead of ptrace-decl.h), how can Snowpatch say build succeeded
> >> (https://patchwork.ozlabs.org/patch/1245807/) ?
> >
> > Which links to:
> > https://openpower.xyz/job/snowpatch/job/snowpatch-linux-sparse/15895//artifact/linux/report.txt
> >
> > The actual build log of which is:
> > https://openpower.xyz/job/snowpatch/job/snowpatch-linux-sparse/15895/artifact/linux/build_new.log
> >
> > Which contains:
> > scripts/Makefile.build:267: recipe for target 'arch/powerpc/kernel/ptrace/ptrace-altivec.o' failed
> > make[3]: *** [arch/powerpc/kernel/ptrace/ptrace-altivec.o] Error 1
> > make[3]: *** Waiting for unfinished jobs....
> > scripts/Makefile.build:505: recipe for target 'arch/powerpc/kernel/ptrace' failed
> > make[2]: *** [arch/powerpc/kernel/ptrace] Error 2
> > make[2]: *** Waiting for unfinished jobs....
> > scripts/Makefile.build:505: recipe for target 'arch/powerpc/kernel' failed
> > make[1]: *** [arch/powerpc/kernel] Error 2
> > make[1]: *** Waiting for unfinished jobs....
> > Makefile:1681: recipe for target 'arch/powerpc' failed
> > make: *** [arch/powerpc] Error 2
> > make: *** Waiting for unfinished jobs....
> >
> > Same for ppc64le:
> > https://openpower.xyz/job/snowpatch/job/snowpatch-linux-sparse/15896/artifact/linux/build_new.log
> >
> >
> > So it seems like snowpatch always reports the build as succeeded even
> > when it fails.
>
> Turns out there was an issue in a recent change in our build script
> which caused build failures to return the wrong exit code and put the
> wrong text in the reports, because of some confusion with bash
> subshells. I've fixed it (I think).
>
> --
> Andrew Donnellan OzLabs, ADL Canberra
> ajd@linux.ibm.com IBM Australia Limited
>
>
prev parent reply other threads:[~2020-02-28 4:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 11:48 [PATCH v4 00/13] Reduce ifdef mess in ptrace Christophe Leroy
2020-02-27 11:48 ` [PATCH v4 01/13] powerpc: move ptrace into a subdirectory Christophe Leroy
2020-02-27 11:48 ` [PATCH v4 02/13] powerpc/ptrace: remove unused header includes Christophe Leroy
2020-02-27 11:48 ` [PATCH v4 03/13] powerpc/ptrace: drop unnecessary #ifdefs CONFIG_PPC64 Christophe Leroy
2020-02-27 11:49 ` [PATCH v4 04/13] powerpc/ptrace: drop PARAMETER_SAVE_AREA_OFFSET Christophe Leroy
2020-02-27 11:49 ` [PATCH v4 05/13] powerpc/ptrace: split out VSX related functions Christophe Leroy
2020-02-27 11:49 ` [PATCH v4 06/13] powerpc/ptrace: split out ALTIVEC " Christophe Leroy
2020-02-28 4:08 ` kbuild test robot
2020-02-27 11:49 ` [PATCH v4 07/13] powerpc/ptrace: split out SPE " Christophe Leroy
2020-02-27 11:49 ` [PATCH v4 08/13] powerpc/ptrace: split out TRANSACTIONAL_MEM " Christophe Leroy
2020-02-27 11:49 ` [PATCH v4 09/13] powerpc/ptrace: move register viewing functions out of ptrace.c Christophe Leroy
2020-02-27 11:49 ` [PATCH v4 10/13] powerpc/ptrace: split out ADV_DEBUG_REGS related functions Christophe Leroy
2020-02-27 11:49 ` [PATCH v4 11/13] powerpc/ptrace: create ptrace_get_debugreg() Christophe Leroy
2020-02-27 11:49 ` [PATCH v4 12/13] powerpc/ptrace: create ppc_gethwdinfo() Christophe Leroy
2020-02-27 11:49 ` [PATCH v4 13/13] powerpc/ptrace: move ptrace_triggered() into hw_breakpoint.c Christophe Leroy
2020-02-27 17:09 ` Christophe Leroy
2020-02-27 22:16 ` Michael Ellerman
2020-02-28 3:59 ` Andrew Donnellan
2020-02-28 4:02 ` Russell Currey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95816cae-565b-40a8-a3bf-4733672c6e91@www.fastmail.com \
--to=ruscur@russell.cc \
--cc=ajd@linux.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).