* [PATCH] powerpc/powermac: Remove pmac_low_i2c_{lock,unlock}()
@ 2026-03-13 19:44 Bart Van Assche
2026-03-14 7:46 ` Christophe Leroy (CS GROUP)
0 siblings, 1 reply; 3+ messages in thread
From: Bart Van Assche @ 2026-03-13 19:44 UTC (permalink / raw)
To: Madhavan Srinivasan, Michael Ellerman
Cc: Nicholas Piggin, Christophe Leroy, linuxppc-dev, Bart Van Assche,
Ingo Molnar, Thomas Gleixner, Kees Cook
I haven't been able to find any callers of the functions mentioned in
the subject in the kernel tree nor in the history of the kernel tree.
Hence, remove these two functions.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
arch/powerpc/include/asm/pmac_low_i2c.h | 4 ---
arch/powerpc/platforms/powermac/low_i2c.c | 34 -----------------------
2 files changed, 38 deletions(-)
diff --git a/arch/powerpc/include/asm/pmac_low_i2c.h b/arch/powerpc/include/asm/pmac_low_i2c.h
index 21bd7297c87f..fead8fae08ab 100644
--- a/arch/powerpc/include/asm/pmac_low_i2c.h
+++ b/arch/powerpc/include/asm/pmac_low_i2c.h
@@ -79,10 +79,6 @@ extern int pmac_i2c_match_adapter(struct device_node *dev,
struct i2c_adapter *adapter);
-/* (legacy) Locking functions exposed to i2c-keywest */
-extern int pmac_low_i2c_lock(struct device_node *np);
-extern int pmac_low_i2c_unlock(struct device_node *np);
-
/* Access functions for platform code */
extern int pmac_i2c_open(struct pmac_i2c_bus *bus, int polled);
extern void pmac_i2c_close(struct pmac_i2c_bus *bus);
diff --git a/arch/powerpc/platforms/powermac/low_i2c.c b/arch/powerpc/platforms/powermac/low_i2c.c
index 73b7f4e8c047..da72a30ab865 100644
--- a/arch/powerpc/platforms/powermac/low_i2c.c
+++ b/arch/powerpc/platforms/powermac/low_i2c.c
@@ -1058,40 +1058,6 @@ int pmac_i2c_match_adapter(struct device_node *dev, struct i2c_adapter *adapter)
}
EXPORT_SYMBOL_GPL(pmac_i2c_match_adapter);
-int pmac_low_i2c_lock(struct device_node *np)
-{
- struct pmac_i2c_bus *bus, *found = NULL;
-
- list_for_each_entry(bus, &pmac_i2c_busses, link) {
- if (np == bus->controller) {
- found = bus;
- break;
- }
- }
- if (!found)
- return -ENODEV;
- return pmac_i2c_open(bus, 0);
-}
-EXPORT_SYMBOL_GPL(pmac_low_i2c_lock);
-
-int pmac_low_i2c_unlock(struct device_node *np)
-{
- struct pmac_i2c_bus *bus, *found = NULL;
-
- list_for_each_entry(bus, &pmac_i2c_busses, link) {
- if (np == bus->controller) {
- found = bus;
- break;
- }
- }
- if (!found)
- return -ENODEV;
- pmac_i2c_close(bus);
- return 0;
-}
-EXPORT_SYMBOL_GPL(pmac_low_i2c_unlock);
-
-
int pmac_i2c_open(struct pmac_i2c_bus *bus, int polled)
{
int rc;
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc/powermac: Remove pmac_low_i2c_{lock,unlock}()
2026-03-13 19:44 [PATCH] powerpc/powermac: Remove pmac_low_i2c_{lock,unlock}() Bart Van Assche
@ 2026-03-14 7:46 ` Christophe Leroy (CS GROUP)
2026-03-16 17:24 ` Bart Van Assche
0 siblings, 1 reply; 3+ messages in thread
From: Christophe Leroy (CS GROUP) @ 2026-03-14 7:46 UTC (permalink / raw)
To: Bart Van Assche, Madhavan Srinivasan, Michael Ellerman
Cc: Nicholas Piggin, linuxppc-dev, Ingo Molnar, Thomas Gleixner,
Kees Cook
Le 13/03/2026 à 20:44, Bart Van Assche a écrit :
> I haven't been able to find any callers of the functions mentioned in
> the subject in the kernel tree nor in the history of the kernel tree.
> Hence, remove these two functions.
As far as I can see it was used by i2c-keywest driver until commit
a28d3af2a26c ("[PATCH] 2/5 powerpc: Rework PowerMac i2c part 2")
a28d3af2a26c89aaa6470ca36edb212e05143d67~:drivers/i2c/busses/i2c-keywest.c:
if (pmac_low_i2c_lock(iface->node))
a28d3af2a26c89aaa6470ca36edb212e05143d67~:drivers/i2c/busses/i2c-keywest.c:
if (pmac_low_i2c_lock(iface->node))
a28d3af2a26c89aaa6470ca36edb212e05143d67~:drivers/i2c/busses/i2c-keywest.c:
if (pmac_low_i2c_lock(np))
a28d3af2a26c89aaa6470ca36edb212e05143d67~:drivers/i2c/busses/i2c-keywest.c:
if (pmac_low_i2c_lock(iface->node))
a28d3af2a26c89aaa6470ca36edb212e05143d67~:drivers/i2c/busses/i2c-keywest.c:
pmac_low_i2c_unlock(iface->node);
a28d3af2a26c89aaa6470ca36edb212e05143d67~:drivers/i2c/busses/i2c-keywest.c:
pmac_low_i2c_unlock(iface->node);
a28d3af2a26c89aaa6470ca36edb212e05143d67~:drivers/i2c/busses/i2c-keywest.c:
pmac_low_i2c_unlock(np);
a28d3af2a26c89aaa6470ca36edb212e05143d67~:drivers/i2c/busses/i2c-keywest.c:
pmac_low_i2c_unlock(np);
a28d3af2a26c89aaa6470ca36edb212e05143d67~:drivers/i2c/busses/i2c-keywest.c:
pmac_low_i2c_unlock(np);
a28d3af2a26c89aaa6470ca36edb212e05143d67~:drivers/i2c/busses/i2c-keywest.c:
pmac_low_i2c_unlock(np);
a28d3af2a26c89aaa6470ca36edb212e05143d67~:drivers/i2c/busses/i2c-keywest.c:
pmac_low_i2c_unlock(iface->node);
>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>
> ---
> arch/powerpc/include/asm/pmac_low_i2c.h | 4 ---
> arch/powerpc/platforms/powermac/low_i2c.c | 34 -----------------------
> 2 files changed, 38 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/pmac_low_i2c.h b/arch/powerpc/include/asm/pmac_low_i2c.h
> index 21bd7297c87f..fead8fae08ab 100644
> --- a/arch/powerpc/include/asm/pmac_low_i2c.h
> +++ b/arch/powerpc/include/asm/pmac_low_i2c.h
> @@ -79,10 +79,6 @@ extern int pmac_i2c_match_adapter(struct device_node *dev,
> struct i2c_adapter *adapter);
>
>
> -/* (legacy) Locking functions exposed to i2c-keywest */
> -extern int pmac_low_i2c_lock(struct device_node *np);
> -extern int pmac_low_i2c_unlock(struct device_node *np);
> -
> /* Access functions for platform code */
> extern int pmac_i2c_open(struct pmac_i2c_bus *bus, int polled);
> extern void pmac_i2c_close(struct pmac_i2c_bus *bus);
> diff --git a/arch/powerpc/platforms/powermac/low_i2c.c b/arch/powerpc/platforms/powermac/low_i2c.c
> index 73b7f4e8c047..da72a30ab865 100644
> --- a/arch/powerpc/platforms/powermac/low_i2c.c
> +++ b/arch/powerpc/platforms/powermac/low_i2c.c
> @@ -1058,40 +1058,6 @@ int pmac_i2c_match_adapter(struct device_node *dev, struct i2c_adapter *adapter)
> }
> EXPORT_SYMBOL_GPL(pmac_i2c_match_adapter);
>
> -int pmac_low_i2c_lock(struct device_node *np)
> -{
> - struct pmac_i2c_bus *bus, *found = NULL;
> -
> - list_for_each_entry(bus, &pmac_i2c_busses, link) {
> - if (np == bus->controller) {
> - found = bus;
> - break;
> - }
> - }
> - if (!found)
> - return -ENODEV;
> - return pmac_i2c_open(bus, 0);
> -}
> -EXPORT_SYMBOL_GPL(pmac_low_i2c_lock);
> -
> -int pmac_low_i2c_unlock(struct device_node *np)
> -{
> - struct pmac_i2c_bus *bus, *found = NULL;
> -
> - list_for_each_entry(bus, &pmac_i2c_busses, link) {
> - if (np == bus->controller) {
> - found = bus;
> - break;
> - }
> - }
> - if (!found)
> - return -ENODEV;
> - pmac_i2c_close(bus);
> - return 0;
> -}
> -EXPORT_SYMBOL_GPL(pmac_low_i2c_unlock);
> -
> -
> int pmac_i2c_open(struct pmac_i2c_bus *bus, int polled)
> {
> int rc;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc/powermac: Remove pmac_low_i2c_{lock,unlock}()
2026-03-14 7:46 ` Christophe Leroy (CS GROUP)
@ 2026-03-16 17:24 ` Bart Van Assche
0 siblings, 0 replies; 3+ messages in thread
From: Bart Van Assche @ 2026-03-16 17:24 UTC (permalink / raw)
To: Christophe Leroy (CS GROUP), Madhavan Srinivasan,
Michael Ellerman
Cc: Nicholas Piggin, linuxppc-dev, Ingo Molnar, Thomas Gleixner,
Kees Cook
On 3/14/26 12:46 AM, Christophe Leroy (CS GROUP) wrote:
> As far as I can see it was used by i2c-keywest driver until commit
> a28d3af2a26c ("[PATCH] 2/5 powerpc: Rework PowerMac i2c part 2")
Thanks Christophe for the feedback. I will integrate your feedback in a
new version of this patch and post it soon.
Bart.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-16 17:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-13 19:44 [PATCH] powerpc/powermac: Remove pmac_low_i2c_{lock,unlock}() Bart Van Assche
2026-03-14 7:46 ` Christophe Leroy (CS GROUP)
2026-03-16 17:24 ` Bart Van Assche
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox