Fix compiler/assembler flags for Ebony platform boot files

Fix compiler/assembler flags for Ebony platform boot files

[David Gibson]

The recent addition of assembler flags for 44x.c and ebony.c in the
bootwrapper to make them compile on certain toolchains was not correct
and could break other platforms.  This patch switches to using a
compiler flag instead, which implies the appropriate assembler flag,
and also stops the compiler itself generating instructions which are
invalid for the platform in question.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

Index: working-2.6/arch/powerpc/boot/Makefile
===================================================================
--- working-2.6.orig/arch/powerpc/boot/Makefile	2007-05-25 12:57:26.000000000 +1000
+++ working-2.6/arch/powerpc/boot/Makefile	2007-05-25 12:57:48.000000000 +1000
@@ -33,8 +33,8 @@ endif
 
 BOOTCFLAGS	+= -I$(obj) -I$(srctree)/$(obj)
 
-$(obj)/44x.o: BOOTCFLAGS += -Wa,-mbooke
-$(obj)/ebony.o: BOOTCFLAGS += -Wa,-mbooke
+$(obj)/44x.o: BOOTCFLAGS += -mcpu=440
+$(obj)/ebony.o: BOOTCFLAGS += -mcpu=440
 
 zlib       := inffast.c inflate.c inftrees.c
 zlibheader := inffast.h inffixed.h inflate.h inftrees.h infutil.h


-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Re: Fix compiler/assembler flags for Ebony platform boot files

[Josh Boyer]

On Fri, 2007-05-25 at 13:19 +1000, David Gibson wrote:
> The recent addition of assembler flags for 44x.c and ebony.c in the
> bootwrapper to make them compile on certain toolchains was not correct
> and could break other platforms.  This patch switches to using a
> compiler flag instead, which implies the appropriate assembler flag,
> and also stops the compiler itself generating instructions which are
> invalid for the platform in question.

This looks good to me, but I don't have one of the failing toolchains.
Dave, can you test this patch out?

josh

Re: Fix compiler/assembler flags for Ebony platform boot files

[Segher Boessenkool]

> The recent addition of assembler flags for 44x.c and ebony.c in the
> bootwrapper to make them compile on certain toolchains was not correct
> and could break other platforms.  This patch switches to using a
> compiler flag instead, which implies the appropriate assembler flag,
> and also stops the compiler itself generating instructions which are
> invalid for the platform in question.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

Acked-by: Segher Boessenkool <segher@kernel.crashing.org>

Re: Fix compiler/assembler flags for Ebony platform boot files

[Segher Boessenkool]

> This looks good to me, but I don't have one of the failing toolchains.
> Dave, can you test this patch out?

You can test by using   make CC="gcc -mcpu=e500" ...


Segher

Re: Fix compiler/assembler flags for Ebony platform boot files

[Dave Jiang]

Josh Boyer wrote:
> On Fri, 2007-05-25 at 13:19 +1000, David Gibson wrote:
>> The recent addition of assembler flags for 44x.c and ebony.c in the
>> bootwrapper to make them compile on certain toolchains was not correct
>> and could break other platforms.  This patch switches to using a
>> compiler flag instead, which implies the appropriate assembler flag,
>> and also stops the compiler itself generating instructions which are
>> invalid for the platform in question.
> 
> This looks good to me, but I don't have one of the failing toolchains.
> Dave, can you test this patch out?
> 
> josh
> 

Built ok for me after the patch.