* [PATCH -next] tpm: ibmvtpm: Correct the return value in tpm_ibmvtpm_probe()
@ 2022-03-18 6:02 Xiu Jianfeng
2022-03-18 13:54 ` Stefan Berger
2022-03-20 21:21 ` Jarkko Sakkinen
0 siblings, 2 replies; 4+ messages in thread
From: Xiu Jianfeng @ 2022-03-18 6:02 UTC (permalink / raw)
To: mpe, benh, paulus, peterhuewe, jarkko, jgg, nayna, stefanb
Cc: linux-integrity, linuxppc-dev, linux-kernel
Currently it returns zero when CRQ response timed out, it should return
an error code instead.
Fixes: d8d74ea3c002 ("tpm: ibmvtpm: Wait for buffer to be set before proceeding")
Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
---
drivers/char/tpm/tpm_ibmvtpm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
index 3af4c07a9342..d3989b257f42 100644
--- a/drivers/char/tpm/tpm_ibmvtpm.c
+++ b/drivers/char/tpm/tpm_ibmvtpm.c
@@ -681,6 +681,7 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev,
if (!wait_event_timeout(ibmvtpm->crq_queue.wq,
ibmvtpm->rtce_buf != NULL,
HZ)) {
+ rc = -ENODEV;
dev_err(dev, "CRQ response timed out\n");
goto init_irq_cleanup;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH -next] tpm: ibmvtpm: Correct the return value in tpm_ibmvtpm_probe()
2022-03-18 6:02 [PATCH -next] tpm: ibmvtpm: Correct the return value in tpm_ibmvtpm_probe() Xiu Jianfeng
@ 2022-03-18 13:54 ` Stefan Berger
2022-03-20 21:23 ` Jarkko Sakkinen
2022-03-20 21:21 ` Jarkko Sakkinen
1 sibling, 1 reply; 4+ messages in thread
From: Stefan Berger @ 2022-03-18 13:54 UTC (permalink / raw)
To: Xiu Jianfeng, mpe, benh, paulus, peterhuewe, jarkko, jgg, nayna
Cc: linux-integrity, linuxppc-dev, linux-kernel
On 3/18/22 02:02, Xiu Jianfeng wrote:
> Currently it returns zero when CRQ response timed out, it should return
> an error code instead.
>
> Fixes: d8d74ea3c002 ("tpm: ibmvtpm: Wait for buffer to be set before proceeding")
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
> ---
> drivers/char/tpm/tpm_ibmvtpm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
> index 3af4c07a9342..d3989b257f42 100644
> --- a/drivers/char/tpm/tpm_ibmvtpm.c
> +++ b/drivers/char/tpm/tpm_ibmvtpm.c
> @@ -681,6 +681,7 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev,
> if (!wait_event_timeout(ibmvtpm->crq_queue.wq,
> ibmvtpm->rtce_buf != NULL,
> HZ)) {
> + rc = -ENODEV;
> dev_err(dev, "CRQ response timed out\n");
> goto init_irq_cleanup;
> }
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] tpm: ibmvtpm: Correct the return value in tpm_ibmvtpm_probe()
2022-03-18 13:54 ` Stefan Berger
@ 2022-03-20 21:23 ` Jarkko Sakkinen
0 siblings, 0 replies; 4+ messages in thread
From: Jarkko Sakkinen @ 2022-03-20 21:23 UTC (permalink / raw)
To: Stefan Berger
Cc: Xiu Jianfeng, nayna, linux-kernel, jgg, paulus, peterhuewe,
linuxppc-dev, linux-integrity
On Fri, Mar 18, 2022 at 09:54:46AM -0400, Stefan Berger wrote:
>
>
> On 3/18/22 02:02, Xiu Jianfeng wrote:
> > Currently it returns zero when CRQ response timed out, it should return
> > an error code instead.
> >
> > Fixes: d8d74ea3c002 ("tpm: ibmvtpm: Wait for buffer to be set before proceeding")
> > Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
>
> Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
Thank you, I applied this.
BR, Jarkko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] tpm: ibmvtpm: Correct the return value in tpm_ibmvtpm_probe()
2022-03-18 6:02 [PATCH -next] tpm: ibmvtpm: Correct the return value in tpm_ibmvtpm_probe() Xiu Jianfeng
2022-03-18 13:54 ` Stefan Berger
@ 2022-03-20 21:21 ` Jarkko Sakkinen
1 sibling, 0 replies; 4+ messages in thread
From: Jarkko Sakkinen @ 2022-03-20 21:21 UTC (permalink / raw)
To: Xiu Jianfeng
Cc: nayna, linux-kernel, jgg, paulus, peterhuewe, linuxppc-dev,
linux-integrity, stefanb
On Fri, Mar 18, 2022 at 02:02:01PM +0800, Xiu Jianfeng wrote:
> Currently it returns zero when CRQ response timed out, it should return
> an error code instead.
>
> Fixes: d8d74ea3c002 ("tpm: ibmvtpm: Wait for buffer to be set before proceeding")
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
> ---
> drivers/char/tpm/tpm_ibmvtpm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
> index 3af4c07a9342..d3989b257f42 100644
> --- a/drivers/char/tpm/tpm_ibmvtpm.c
> +++ b/drivers/char/tpm/tpm_ibmvtpm.c
> @@ -681,6 +681,7 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev,
> if (!wait_event_timeout(ibmvtpm->crq_queue.wq,
> ibmvtpm->rtce_buf != NULL,
> HZ)) {
> + rc = -ENODEV;
> dev_err(dev, "CRQ response timed out\n");
> goto init_irq_cleanup;
> }
> --
> 2.17.1
>
Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
This will require reviewed by from someone who knows this driver
better.
BR, Jarkko
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-20 21:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-18 6:02 [PATCH -next] tpm: ibmvtpm: Correct the return value in tpm_ibmvtpm_probe() Xiu Jianfeng
2022-03-18 13:54 ` Stefan Berger
2022-03-20 21:23 ` Jarkko Sakkinen
2022-03-20 21:21 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).