From: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>,
bhelgaas@google.com, paulus@samba.org, mpe@ellerman.id.au,
benh@kernel.crashing.org
Cc: linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] PCI: hotplug: constify attribute_group structures.
Date: Tue, 11 Jul 2017 11:55:40 -0700 [thread overview]
Message-ID: <97d8f7b5-7939-6abb-4883-4582a16f374e@linux.vnet.ibm.com> (raw)
In-Reply-To: <1499765324-617-2-git-send-email-arvind.yadav.cs@gmail.com>
On 07/11/2017 02:28 AM, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work
> with const attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 418 160 8 586 24a drivers/pci/hotplug/rpadlpar_sysfs.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 482 96 8 586 232 drivers/pci/hotplug/rpadlpar_sysfs.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Reviewed-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
prev parent reply other threads:[~2017-07-11 18:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 9:28 [PATCH 0/3] constify pci attribute_group structures Arvind Yadav
2017-07-11 9:28 ` [PATCH 3/3] PCI: hotplug: constify " Arvind Yadav
2017-07-11 18:55 ` Tyrel Datwyler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97d8f7b5-7939-6abb-4883-4582a16f374e@linux.vnet.ibm.com \
--to=tyreld@linux.vnet.ibm.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).