From: Milton Miller <miltonm@bga.com>
To: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Cc: linux-ppc <linuxppc-dev@ozlabs.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] 2.6.28-git4 - powerpc - drivers build fails with !CONFIG_VIOPATH
Date: Mon, 5 Jan 2009 07:33:32 -0600 [thread overview]
Message-ID: <98d6aef17cba9d835d7866745f811dc7@bga.com> (raw)
In-Reply-To: <20090104182441.GA5086@linux.vnet.ibm.com>
On Jan 4, 2009, at 12:24 PM, Kamalesh Babulal wrote:
> Hi Milton,
>
> Thanks for the review comments, I am resending the patch with the
> changes you have recommended.
>
> Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Better, but you didn't include the change log, nor did you respond to
Stephen's reply suggesting that all users be converted to select
viopath (versus the proposed 2 select and 5 get it via depends and
default y).
milton
next prev parent reply other threads:[~2009-01-05 13:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-04 8:54 [PATCH] 2.6.28-git4 - powerpc - drivers build fails with !CONFIG_VIOPATH Milton Miller
2009-01-04 12:12 ` Stephen Rothwell
2009-01-04 18:24 ` Kamalesh Babulal
2009-01-05 13:33 ` Milton Miller [this message]
2009-01-06 7:25 ` Kamalesh Babulal
2009-01-06 7:31 ` Sam Ravnborg
2009-01-06 9:38 ` Kamalesh Babulal
2009-01-06 10:46 ` Sam Ravnborg
2009-01-06 15:57 ` Kamalesh Babulal
2009-01-06 16:40 ` Sam Ravnborg
-- strict thread matches above, loose matches on Subject: below --
2009-01-03 19:13 Kamalesh Babulal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98d6aef17cba9d835d7866745f811dc7@bga.com \
--to=miltonm@bga.com \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).