From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62354C433DB for ; Fri, 15 Jan 2021 08:24:04 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C74E322583 for ; Fri, 15 Jan 2021 08:24:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C74E322583 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4DHDjY58HJzDsgv for ; Fri, 15 Jan 2021 19:24:01 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.218.45; helo=mail-ej1-f45.google.com; envelope-from=jirislaby@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=fail (p=none dis=none) header.from=kernel.org Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4DHDdV3DGdzDsdC for ; Fri, 15 Jan 2021 19:20:29 +1100 (AEDT) Received: by mail-ej1-f45.google.com with SMTP id q22so12092297eja.2 for ; Fri, 15 Jan 2021 00:20:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jEyFAI8Tiov/SBHpNo3029tSX/H+CCtTPEByvcBUUrQ=; b=DoSYGLPFuASAkBnAH3tqWnbGsJVBBvAMFuNUCmVRDfWyM0Zv9pbgFdihBNxK353S6l bUlQomorDNlUayCvGsRuJv3L+EdUEQowuejgY/nSaDou2TuHYcvG/InOI0lulf+MaPf/ vAn7TJclGlcgv4WfML4awRwlw/WMkQgcj8gkUfUgvmhBwOGGoGd1Gnqkv0jGNgwepOYj ZMAF+F0pqGoJJQCEsIkRiwSmFWZhKqfZlMkY8lbC9F4AHY2wlOTLDapsNVlYjkZFT5AF HT/VvrfBwC+ntv0M7AnhbDARYDsli7bD4mcDYQMnayT/pR3dgn1ple+lgg+jDLhxWVTR 7w0w== X-Gm-Message-State: AOAM5315hmh0jMLNkY0knn1r3HbjbEkAu9B7LqhE1hC4i7hoLEVFueSY yZ68fZ6cwoXeNGQpbsYuuyA= X-Google-Smtp-Source: ABdhPJza8YUJJ+T+zmo3FTE2Q4CTVcyXE8IE5bnUQXWXBR8ur4YO/4xQ/EJM/R7aABO9UuVSd7Ptxw== X-Received: by 2002:a17:906:4893:: with SMTP id v19mr77844ejq.454.1610698825555; Fri, 15 Jan 2021 00:20:25 -0800 (PST) Received: from ?IPv6:2a0b:e7c0:0:107::49? ([2a0b:e7c0:0:107::49]) by smtp.gmail.com with ESMTPSA id h23sm2923600ejg.37.2021.01.15.00.20.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Jan 2021 00:20:24 -0800 (PST) Subject: Re: [PATCH 2/3] tty: vcc: Drop unnecessary if block To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Greg Kroah-Hartman References: <20210114175718.137483-1-u.kleine-koenig@pengutronix.de> <20210114175718.137483-3-u.kleine-koenig@pengutronix.de> From: Jiri Slaby Message-ID: <9a1c68fc-f3bf-79e7-e2ae-238059241e2f@kernel.org> Date: Fri, 15 Jan 2021 09:20:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210114175718.137483-3-u.kleine-koenig@pengutronix.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, "David S . Miller" , linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 14. 01. 21, 18:57, Uwe Kleine-König wrote: > If vcc_probe() succeeded dev_set_drvdata() is called with a non-NULL > value, and if vcc_probe() failed vcc_remove() isn't called. > > So there is no way dev_get_drvdata() can return NULL in vcc_remove() and > the check can just go away. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Jiri Slaby > --- > drivers/tty/vcc.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/tty/vcc.c b/drivers/tty/vcc.c > index 9ffd42e333b8..d9b0dc6deae9 100644 > --- a/drivers/tty/vcc.c > +++ b/drivers/tty/vcc.c > @@ -681,9 +681,6 @@ static int vcc_remove(struct vio_dev *vdev) > { > struct vcc_port *port = dev_get_drvdata(&vdev->dev); > > - if (!port) > - return -ENODEV; > - > del_timer_sync(&port->rx_timer); > del_timer_sync(&port->tx_timer); > > -- js