* [PATCH] tty: hvc: remove set but unused variable
@ 2023-09-08 6:17 Bo Liu
2023-09-11 7:16 ` Jiri Slaby
0 siblings, 1 reply; 2+ messages in thread
From: Bo Liu @ 2023-09-08 6:17 UTC (permalink / raw)
To: gregkh, jirislaby; +Cc: Bo Liu, linuxppc-dev, linux-kernel, linux-serial
The local variable vdev in hvcs_destruct_port() is set
but not used. Remove the variable and related code.
Signed-off-by: Bo Liu <liubo03@inspur.com>
---
drivers/tty/hvc/hvcs.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/tty/hvc/hvcs.c b/drivers/tty/hvc/hvcs.c
index d29fdfe9d93d..b537d1fb67d4 100644
--- a/drivers/tty/hvc/hvcs.c
+++ b/drivers/tty/hvc/hvcs.c
@@ -664,7 +664,6 @@ static void hvcs_return_index(int index)
static void hvcs_destruct_port(struct tty_port *p)
{
struct hvcs_struct *hvcsd = container_of(p, struct hvcs_struct, port);
- struct vio_dev *vdev;
struct completion *comp;
unsigned long flags;
@@ -686,7 +685,6 @@ static void hvcs_destruct_port(struct tty_port *p)
printk(KERN_INFO "HVCS: Destroyed hvcs_struct for vty-server@%X.\n",
hvcsd->vdev->unit_address);
- vdev = hvcsd->vdev;
hvcsd->vdev = NULL;
hvcsd->p_unit_address = 0;
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tty: hvc: remove set but unused variable
2023-09-08 6:17 [PATCH] tty: hvc: remove set but unused variable Bo Liu
@ 2023-09-11 7:16 ` Jiri Slaby
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Slaby @ 2023-09-11 7:16 UTC (permalink / raw)
To: Bo Liu, gregkh; +Cc: linuxppc-dev, linux-kernel, linux-serial
On 08. 09. 23, 8:17, Bo Liu wrote:
> The local variable vdev in hvcs_destruct_port() is set
> but not used. Remove the variable and related code.
>
> Signed-off-by: Bo Liu <liubo03@inspur.com>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
--
js
suse labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-11 7:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-08 6:17 [PATCH] tty: hvc: remove set but unused variable Bo Liu
2023-09-11 7:16 ` Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).