linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Benjamin Herrenschmidt <benh@au1.ibm.com>
Cc: Christian Rund <Christian.Rund@de.ibm.com>,
	Hartmut Penner <HPENNER@de.ibm.com>,
	Murali N Iyer <mniyer@us.ibm.com>,
	linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: EMAC OF binding....
Date: Tue, 9 Jan 2007 17:08:34 +0100	[thread overview]
Message-ID: <9a44c3bbc4ab67921f784f16991889bd@kernel.crashing.org> (raw)
In-Reply-To: <1168302607.22458.242.camel@localhost.localdomain>

> I'm not sure I follow you... for example, I may have some clock contro
> register somewhere with one bit enabling EMAC 0 clock and one bit
> enabling EMAC 1 clock...
>
> Easier to call some platform clock management giving my device-node as
> an argument and have that code extract the EMAC "index" from the DT 
> from
> my node.

You give the phandle of your emac node as argument, that
works just fine with what I proposed too (the SoC PM node
knows the phandles of the emac's).  I think your way isn't
all that clean architecturally and can easily lead to
problems later on; the emac shouldn't have to know *anything*
about the structure of the SoC.

But feel free to do what you want, it's certainly not
a *huge* problem ;-)


Segher

  reply	other threads:[~2007-01-09 16:10 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <OF7EF2F643.75F7008B-ON8625725D.00157658-8625725D.00167CB4@au1.ibm.com>
2007-01-08  6:09 ` EMAC OF binding Benjamin Herrenschmidt
2007-01-08  6:38   ` Segher Boessenkool
2007-01-08 20:32     ` Benjamin Herrenschmidt
2007-01-08 22:12       ` David Gibson
2007-01-08 23:34         ` Segher Boessenkool
2007-01-08 22:40       ` Segher Boessenkool
2007-01-08 22:47         ` Benjamin Herrenschmidt
2007-01-08 23:27           ` Segher Boessenkool
2007-01-09  0:30             ` Benjamin Herrenschmidt
2007-01-09 16:08               ` Segher Boessenkool [this message]
2007-01-09 21:45                 ` Benjamin Herrenschmidt
2007-01-09 21:57                   ` Segher Boessenkool
2007-01-09 22:04                     ` Benjamin Herrenschmidt
2007-01-09 22:17                       ` Segher Boessenkool
2007-01-09 22:41                         ` David Gibson
2007-01-09 22:42                         ` Benjamin Herrenschmidt
2007-01-09 23:05                           ` Segher Boessenkool
2007-01-30  0:25     ` Benjamin Herrenschmidt
2007-01-30  0:45       ` Kumar Gala
2007-01-30  0:54         ` David Gibson
2007-01-30  1:50         ` Benjamin Herrenschmidt
2007-01-30  2:49           ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9a44c3bbc4ab67921f784f16991889bd@kernel.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=Christian.Rund@de.ibm.com \
    --cc=HPENNER@de.ibm.com \
    --cc=benh@au1.ibm.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mniyer@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).