From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from qb-out-0506.google.com (qb-out-0506.google.com [72.14.204.234]) by ozlabs.org (Postfix) with ESMTP id D1E91DDE06 for ; Sun, 22 Jul 2007 02:48:15 +1000 (EST) Received: by qb-out-0506.google.com with SMTP id e11so1818597qbe for ; Sat, 21 Jul 2007 09:48:13 -0700 (PDT) Message-ID: <9a8748490707210948k468f8f32k718d84279aa56ce9@mail.gmail.com> Date: Sat, 21 Jul 2007 18:48:07 +0200 From: "Jesper Juhl" To: "Chris Snook" Subject: Re: [PATCH][12/37] Clean up duplicate includes in drivers/net/ In-Reply-To: <46A236FC.2080300@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed References: <200707211702.46375.jesper.juhl@gmail.com> <46A236FC.2080300@redhat.com> Cc: info@netxen.com, Luke Yang , Judy Fischbach , Patrick McHardy , bonding-devel@lists.sourceforge.net, Bryan Wu , kong.lai@tundra.com, Jay Vosburgh , James Morris , linuxppc-embedded@ozlabs.org, Alexey Kuznetsov , Alex V Lasso , Ulrich Kunitz , Chad Tindel , Amit S Kale , Jay Cliburn , Samuel Ortiz , Daniel Drake , Brian Pugh , viro@ftp.linux.org.uk, alexandre.bounine@tundra.com, Pantelis Antoniou , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, Linux Kernel Mailing List , Ralf Baechle , Vitaly Bordug , Lukasz Stelmach , Ron Mercer , atl1-devel@lists.sourceforge.net, Andrew Morton , "David S. Miller" , James P Ketrenos List-Id: Linux on Embedded PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 21/07/07, Chris Snook wrote: > Jesper Juhl wrote: > > Hi, > > > > This patch cleans up duplicate includes in > > drivers/net/ > > > > > > Signed-off-by: Jesper Juhl > > --- > > > > diff --git a/drivers/net/atl1/atl1_main.c b/drivers/net/atl1/atl1_main.c > > index fd1e156..4a18b88 100644 > > --- a/drivers/net/atl1/atl1_main.c > > +++ b/drivers/net/atl1/atl1_main.c > > @@ -75,7 +75,6 @@ > > #include > > #include > > #include > > -#include > > #include > > > > #include > > Define "duplicate". I ask because this patch just got posted a few days ago: > duplicate == present more than once in the same source file. Did you try looking at the includes in the source file the patch modifies? > Signed-off-by: Al Viro > --- > drivers/net/atl1/atl1_main.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/atl1/atl1_main.c b/drivers/net/atl1/atl1_main.c > index 4a18b88..fd1e156 100644 > --- a/drivers/net/atl1/atl1_main.c > +++ b/drivers/net/atl1/atl1_main.c > @@ -75,6 +75,7 @@ > #include > #include > #include > +#include > #include > > #include > > I've always been under the impression that one should include all the files > whose contents you use directly, because other includes that happen to include > them might no longer need to in the future and cease including them. I agree completely. But that's completely beside the point here. Before Al's patch, drivers/net/atl1/atl1_main.c already contained "#include ". > You can > fight it out with Al if you feel like it. I'm keeping the rest of the CC list > because the other maintainers might have similar feelings about the > appropriateness of these includes in their drivers. > Take a look at the file. These are the includes at the top of drivers/net/atl1/atl1_main.c : ... #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include <--- Here we have linux/interrupt.h #include #include #include #include #include #include #include #include #include #include #include <--- And here we include it again. #include #include #include #include "atl1.h" ... Now please tell me why it makes sense to include the same header twice and why my patch that removes the duplicate does not make sense. -- Jesper Juhl Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html