From: Mark Brown <broonie@kernel.org>
To: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: shengjiu.wang@gmail.com, Xiubo.Lee@gmail.com, festevam@gmail.com,
nicoleotsuka@gmail.com, lgirdwood@gmail.com, perex@perex.cz,
tiwai@suse.com, linux-sound@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/3] ASoC: fsl_sai: add bitcount and timestamp controls
Date: Mon, 9 Mar 2026 22:42:36 +0000 [thread overview]
Message-ID: <9c7c407e-ced4-455a-a8a8-54b42f706130@sirena.org.uk> (raw)
In-Reply-To: <20260309083530.2977163-3-shengjiu.wang@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 862 bytes --]
On Mon, Mar 09, 2026 at 04:35:29PM +0800, Shengjiu Wang wrote:
> + SOC_SINGLE_EXT("Transmit Timestamp Reset", FSL_SAI_TTCTL, FSL_SAI_xTCTL_RTSC_SHIFT, 1, 0,
> + fsl_asoc_get_volsw, fsl_asoc_put_volsw),
> + SOC_SINGLE_EXT("Transmit Bit Counter Reset", FSL_SAI_TTCTL, FSL_SAI_xTCTL_RBC_SHIFT, 1, 0,
> + fsl_asoc_get_volsw, fsl_asoc_put_volsw),
Sorry, I should've spotted this on earlier review (though surely you
will have seen this on running mixer-test?) but these fail:
# # verdinwm8904.2 Transmit Timestamp Reset
# # 0.2 Transmit Timestamp Reset is a writeable boolean but not a Switch
# not ok 366 name.verdinwm8904.2
# ok 367 write_default.verdinwm8904.2
# # Spurious event generated for Transmit Timestamp Reset
The reset controls should be volatile, always read zero and not generate
events as a result. The name needs fixing as well.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-03-09 22:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 8:35 [PATCH v5 0/3] ASoC: fsl: add bitcount and timestamp controls Shengjiu Wang
2026-03-09 8:35 ` [PATCH v5 1/3] ASoC: fsl_utils: Add snd_kcontrol functions for specific cases Shengjiu Wang
2026-03-09 8:35 ` [PATCH v5 2/3] ASoC: fsl_sai: add bitcount and timestamp controls Shengjiu Wang
2026-03-09 22:42 ` Mark Brown [this message]
2026-03-10 9:29 ` Shengjiu Wang
2026-03-09 8:35 ` [PATCH v5 3/3] ASoC: fsl_xcvr: " Shengjiu Wang
2026-03-09 22:43 ` Mark Brown
2026-03-12 17:34 ` [PATCH v5 0/3] ASoC: fsl: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c7c407e-ced4-455a-a8a8-54b42f706130@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Xiubo.Lee@gmail.com \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=shengjiu.wang@gmail.com \
--cc=shengjiu.wang@nxp.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox