Re: Domen's MPC5200 FEC cleanup patch.

["Jon Smirl" <jonsmirl@gmail.com>]

On 9/15/07, Jon Smirl <jonsmirl@gmail.com> wrote:
> On 9/15/07, Domen Puncer <domen.puncer@telargo.com> wrote:
> > On 15/09/07 00:28 -0400, Jon Smirl wrote:
> > > On 9/14/07, Jon Smirl <jonsmirl@gmail.com> wrote:
> > > > This patch doesn't seem to working quite right on my hardware (Phytec
> > > > pcm030). At boot I get a long pause.
> > >
> > > It also doesn't compile if  CONFIG_FEC_MPC52xx_MDIO is undefined.
> >
> > Right, darn.
> > Try this one: http://coderock.org/tmp/fec-v3rc1/
>
>     0.776407] 0x00f40000-0x00f80000 : "oftree"
> [    0.782101] 0x00f80000-0x01000000 : "space"
> [    0.788100] TCP cubic registered
> [    0.791427] NET: Registered protocol family 1
> [    0.795904] NET: Registered protocol family 17
> [    1.305579] f0003000:00 not found
> [    1.308985] net eth0: phy_connect failed
> [    1.312961] net eth0: fec_init_phy failed
> [    1.317188] IP-Config: Failed to open eth0
> [    1.321362] IP-Config: No network devices available.
> [    1.326973] Looking up port of RPC 100003/3 on 192.168.1.4

This fixes the problem....

diff --git a/drivers/net/fec_mpc52xx/fec.c b/drivers/net/fec_mpc52xx/fec.c
index 922e9a8..c4442e0 100644
--- a/drivers/net/fec_mpc52xx/fec.c
+++ b/drivers/net/fec_mpc52xx/fec.c
@@ -1087,11 +1087,13 @@ static struct of_platform_driver mpc52xx_fec_driver = {
 /* ======================================================================== */
 /* Module                                                                   */
 /* ======================================================================== */
+extern int fec_mdio_init(void);
+void fec_mdio_exit(void);

 static int __init
 mpc52xx_fec_init(void)
 {
-#ifdef FEC_MPC52xx_MDIO
+#ifdef CONFIG_FEC_MPC52xx_MDIO
        int ret;
        ret = fec_mdio_init();
        if (ret) {
@@ -1106,7 +1108,7 @@ static void __exit
 mpc52xx_fec_exit(void)
 {
        of_unregister_platform_driver(&mpc52xx_fec_driver);
-#ifdef FEC_MPC52xx_MDIO
+#ifdef CONFIG_FEC_MPC52xx_MDIO
        fec_mdio_exit();
 #endif
 }


-- 
Jon Smirl
jonsmirl@gmail.com