Re: [RFC PATCH v0.1] net driver: mpc52xx fec

["Jon Smirl" <jonsmirl@gmail.com>]

On 9/27/07, Juergen Beisert <jbe@pengutronix.de> wrote:
> On Friday 10 August 2007 11:51, Domen Puncer wrote:
> > Not for merge (yet)! But please do review.
> >
> > fec_mpc52xx driver (not in-tree, but floating around) isn't in very
> > good shape, so I tried to change that.
> > Diff against original is quite big (fec_phy.c is completely rewritten)
> > and confuzing, so I'm including whole drivers/net/fec_mpc52xx/ .
> >
> > I still have 'make CONFIG_FEC_MPC52xx_MDIO=n compile and work' on my
> > TODO, maybe even ethtool support.
>
> Currently I'm trying with your fec driver and Sylvain Munaut's bestcomm driver
> *and* rt-preemt 2.6.23-rc8-rt1 and now I'm getting this error while stress
> test the network:
>
> BUG: scheduling while atomic: softirq-timer/0/0x00000002/5, CPU#0
> Call Trace:
> [c0309e00] [c0007ddc] show_stack+0x3c/0x194 (unreliable)
> [c0309e30] [c0017934] __schedule_bug+0x38/0x48
> [c0309e40] [c01c8f24] __schedule+0x3e8/0x428
> [c0309e70] [c01c96d4] schedule+0x54/0xf0
> [c0309e80] [c01c9e8c] schedule_timeout+0x68/0xe4
> [c0309ec0] [c00282dc] msleep+0x1c/0x34
> [c0309ed0] [c0125fb8] fec_stop+0xbc/0x1a8
> [c0309ef0] [c0126530] fec_reset+0x20/0xb0
> [c0309f10] [c0127840] fec_tx_timeout+0x3c/0xa4
> [c0309f30] [c016b5dc] dev_watchdog+0x13c/0x14c
> [c0309f50] [c0027c90] run_timer_softirq+0x2e4/0x444
> [c0309f90] [c00239a4] ksoftirqd+0x134/0x214
> [c0309fd0] [c0034d94] kthread+0x48/0x84
> [c0309ff0] [c000f828] kernel_thread+0x44/0x60
>
> Do you have an idea what happens?

The call to msleep() is inside a block protected with
:#define in_interrupt()          (irq_count())
if (!in_interrupt)

The stack trace looks like it is in a timer interrupt so shouldn't
irq_count be non-zero?
Could there be some lack of coordination on irq_count and the timer
tick with the preempt patch applied?  Or does irq_count() not count
soft irqs?

(!in_interrupt) may be the wrong way to protect this code.

-- 
Jon Smirl
jonsmirl@gmail.com