From: "Jon Smirl" <jonsmirl@gmail.com>
To: Tjernlund <tjernlund@tjernlund.se>
Cc: linuxppc-dev@ozlabs.org, i2c@lm-sensors.org
Subject: Re: i2c-mpc.c driver issues
Date: Wed, 24 Oct 2007 18:44:05 -0400 [thread overview]
Message-ID: <9e4733910710241544p673b3f7dnc0c8accf191b4bbd@mail.gmail.com> (raw)
In-Reply-To: <019001c81681$b5d449c0$5267a8c0@Jocke>
On 10/24/07, Tjernlund <tjernlund@tjernlund.se> wrote:
> While browsing the i2c-mpc.c driver I noticed some things that look odd
> to me so I figured I report them. Could not find a maintainer in the MAINTANERS file
> so I sent here, cc:ed linuxppc-dev as well.
There appear to be more issues with this driver. It is still
registering as platform driver instead of a of_platform driver.
On the mpc5200 the probe function for platform drivers is not getting
called, so fsl_i2c_probe never gets called. It's not clear to me that
this driver is functioning on the mpc5200.
> 1) There are a lot of return -1 error code that is propagated back to
> userspace. Should be changed to proper -Exxx codes.
>
> 2) mpc_read(), according to the comment below it sends a STOP condition here but
> this function does not known if this is the last read or not. mpc_xfer is
> the one that knows when the transaction is over and should send the stop, which it already
> does.
>
> /* Generate stop on last byte */
> if (i == length - 1)
> writeccr(i2c, CCR_MIEN | CCR_MEN | CCR_TXAK);
>
> Jocke
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>
--
Jon Smirl
jonsmirl@gmail.com
next prev parent reply other threads:[~2007-10-24 22:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 21:06 i2c-mpc.c driver issues Tjernlund
2007-10-24 22:44 ` Jon Smirl [this message]
2007-10-26 9:53 ` [i2c] " Jean Delvare
2007-10-26 11:21 ` Joakim Tjernlund
2007-10-27 20:52 ` Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e4733910710241544p673b3f7dnc0c8accf191b4bbd@mail.gmail.com \
--to=jonsmirl@gmail.com \
--cc=i2c@lm-sensors.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=tjernlund@tjernlund.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).