From: "Jon Smirl" <jonsmirl@gmail.com>
To: "PowerPC dev list" <Linuxppc-dev@ozlabs.org>
Subject: IRQs in i2c-mpc.c
Date: Sat, 10 Nov 2007 14:44:28 -0500 [thread overview]
Message-ID: <9e4733910711101144r3f8745dbs572aefa8658e1312@mail.gmail.com> (raw)
I'm doing final clean up the i2c open firmware support. What is the
intention of this code? Is it meant for a missing IRQ attribute to
return a zero and not get an IRQ for the device? Does the device
function without an IRQ? If so, it needs a comment explaining things.
Otherwise IRQ of zero should be an error.
i2c->irq = irq_of_parse_and_map(op->node, 0);
if (i2c->irq <= 0) {
result = -ENXIO;
goto fail_irq;
}
if (i2c->irq != 0)
if ((result = request_irq(i2c->irq, mpc_i2c_isr,
IRQF_SHARED, "i2c-mpc", i2c)) < 0) {
printk(KERN_ERR "i2c-mpc - failed to attach interrupt\n");
goto fail_irq;
}
--
Jon Smirl
jonsmirl@gmail.com
next reply other threads:[~2007-11-10 19:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-10 19:44 Jon Smirl [this message]
2007-11-10 23:09 ` IRQs in i2c-mpc.c Kumar Gala
2007-11-10 23:16 ` Jon Smirl
2007-11-10 23:18 ` Kumar Gala
2007-11-10 23:44 ` Jon Smirl
2007-11-11 6:27 ` Benjamin Herrenschmidt
2007-11-11 15:34 ` Jon Smirl
2007-11-11 20:44 ` Benjamin Herrenschmidt
2007-11-11 6:26 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e4733910711101144r3f8745dbs572aefa8658e1312@mail.gmail.com \
--to=jonsmirl@gmail.com \
--cc=Linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).