From: "Jon Smirl" <jonsmirl@gmail.com>
To: benh@kernel.crashing.org
Cc: PowerPC dev list <Linuxppc-dev@ozlabs.org>
Subject: Re: pcspkr device, pnpPNP,100
Date: Sun, 11 Nov 2007 19:07:23 -0500 [thread overview]
Message-ID: <9e4733910711111607i35294d3ja43e1c616a3427bd@mail.gmail.com> (raw)
In-Reply-To: <1194825784.18185.0.camel@pasglop>
On 11/11/07, Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> On Sun, 2007-11-11 at 18:35 -0500, Jon Smirl wrote:
> > Which platform does pcspkr device, pnpPNP,100 belong to, amiga? I'd
> > like to IFDEF add_pcspkr(void) in setup-common.c for the right
> > platform.
>
> #ifdef is evil. What about multiplatform kernels ? Just test for the
> presence of the device in the device-tree (use a platform driver maybe)
This code should be in a device driver so that it can be selected with
Kconfig. Can we #ifdef it now as a hint? I could make it a device
driver but I don't have any hardware to test it on.
I'm trying to get the mpc5200 kernel to build with platform bus turned
off (only of_platform bus). I'm almost there, just a couple more odd
places to patch up.
>
> Ben.
>
>
>
--
Jon Smirl
jonsmirl@gmail.com
next prev parent reply other threads:[~2007-11-12 0:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-11 23:35 pcspkr device, pnpPNP,100 Jon Smirl
2007-11-12 0:03 ` Benjamin Herrenschmidt
2007-11-12 0:07 ` Jon Smirl [this message]
2007-11-12 0:09 ` Benjamin Herrenschmidt
2007-11-12 0:18 ` Jon Smirl
2007-11-12 1:07 ` Benjamin Herrenschmidt
2007-11-12 10:48 ` Geert Uytterhoeven
2007-11-12 13:51 ` Jon Smirl
2007-11-12 13:57 ` Geert Uytterhoeven
2007-11-12 14:50 ` Gerhard Pircher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e4733910711111607i35294d3ja43e1c616a3427bd@mail.gmail.com \
--to=jonsmirl@gmail.com \
--cc=Linuxppc-dev@ozlabs.org \
--cc=benh@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).