From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <9e4733910711111618l5190dee3jd8e0aa8f9b78ebf4@mail.gmail.com> Date: Sun, 11 Nov 2007 19:18:14 -0500 From: "Jon Smirl" To: benh@kernel.crashing.org Subject: Re: pcspkr device, pnpPNP,100 In-Reply-To: <1194826191.18185.6.camel@pasglop> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <9e4733910711111535w6ffdfa97x4bed07eb84d4ab13@mail.gmail.com> <1194825784.18185.0.camel@pasglop> <9e4733910711111607i35294d3ja43e1c616a3427bd@mail.gmail.com> <1194826191.18185.6.camel@pasglop> Cc: PowerPC dev list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 11/11/07, Benjamin Herrenschmidt wrote: > > On Sun, 2007-11-11 at 19:07 -0500, Jon Smirl wrote: > > > > This code should be in a device driver so that it can be selected with > > Kconfig. Can we #ifdef it now as a hint? I could make it a device > > driver but I don't have any hardware to test it on. > > > > I'm trying to get the mpc5200 kernel to build with platform bus turned > > off (only of_platform bus). I'm almost there, just a couple more odd > > places to patch up. > > Just don't do platform ifdef's, ever. > > What you can do however is Kconfig options that get selected by > platforms that need a given service, and then use that as an ifdef for > that service. > > A bit like how we select what interrupt controller drivers to built-in > for example. Using this scheme, which platforms should select the pcspkr hardware? -- Jon Smirl jonsmirl@gmail.com