From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rv-out-0910.google.com (rv-out-0910.google.com [209.85.198.189]) by ozlabs.org (Postfix) with ESMTP id 84D69DDEB6 for ; Wed, 12 Dec 2007 09:44:52 +1100 (EST) Received: by rv-out-0910.google.com with SMTP id c27so2048273rvf for ; Tue, 11 Dec 2007 14:44:51 -0800 (PST) Message-ID: <9e4733910712111444v7d6852e7wbf2ff6b0198bcb83@mail.gmail.com> Date: Tue, 11 Dec 2007 17:44:51 -0500 From: "Jon Smirl" To: "Geert Uytterhoeven" Subject: Re: [PATCH 0/5] Series to add device tree naming to i2c In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <20071210183323.12584.88127.stgit@terra.home> Cc: Jean Delvare , Linux/PPC Development , i2c@lm-sensors.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 12/11/07, Geert Uytterhoeven wrote: > On Mon, 10 Dec 2007, Jon Smirl wrote: > > Respin to split error return fixups out of mpc-i2c to of_platform chang= e > > > > The following series implements standard linux module aliasing for i2c = modules > > It then converts the mpc i2c driver from being a platform driver to an = open > > firmware one. I2C device names are picked up from the device tree. Modu= le > > aliasing is used to translate from device tree names into to linux kern= el > > names. Several i2c drivers are updated to use the new aliasing. > > Is there any relationship of these patches with commit > cee37ae4071740cb190d1ac4ddb7aa77484aa7b3? That commit appears to be removing an entry for i2c in mod_devicetable.h. But there was never any code in place to use that struct which is why it was removed. I have added the struct back with a name field instead of an id. My patches also include the code necessary to make it all work. > > Author: Jean Delvare > Date: Sat Oct 13 23:56:29 2007 +0200 > > i2c: Kill struct i2c_device_id > > I2C devices do not have any form of ID as PCI or USB devices have. > No driver uses "MODULE_DEVICE_TABLE(i2c, ...)" because it doesn't > make sense. So we can get rid of struct i2c_device_id and the > associated support code. > > Signed-off-by: Jean Delvare > Cc: Greg KH > > With kind regards, > > Geert Uytterhoeven > Software Architect > > Sony Network and Software Technology Center Europe > The Corporate Village =B7 Da Vincilaan 7-D1 =B7 B-1935 Zaventem =B7 Belgi= um > > Phone: +32 (0)2 700 8453 > Fax: +32 (0)2 700 8622 > E-mail: Geert.Uytterhoeven@sonycom.com > Internet: http://www.sony-europe.com/ > > Sony Network and Software Technology Center Europe > A division of Sony Service Centre (Europe) N.V. > Registered office: Technologielaan 7 =B7 B-1840 Londerzeel =B7 Belgium > VAT BE 0413.825.160 =B7 RPR Brussels > Fortis Bank Zaventem =B7 Swift GEBABEBB08A =B7 IBAN BE39001382358619 --=20 Jon Smirl jonsmirl@gmail.com