Re: [PATCH] ASoC drivers for the Freescale MPC8610 SoC

["Jon Smirl" <jonsmirl@gmail.com>]

On 12/19/07, Timur Tabi <timur@freescale.com> wrote:

> +static struct of_device_id mpc8610_ids[] = {
> +       { .type = "soc", },
> +       {}
> +};
> +
> +static int __init mpc8610_declare_of_platform_devices(void)
> +{
> +       if (!machine_is(mpc86xx_hpcd))
> +               return 0;
> +
> +       /* Without this call, the SSI device driver won't get probed. */
> +       of_platform_bus_probe(NULL, mpc8610_ids, NULL);
> +
> +       return 0;
> +}
> +device_initcall(mpc8610_declare_of_platform_devices);

How is of_platform_bus_probe() supposed to be called? mpc5200/virtex
call it with three NULLs. Is it necessary to name all of the buses in
a of_device_id? If it's not necessary to list the buses the
of_platform_bus_probe() call could be moved to common code.

Are these buses?
        { .compatible = "ibm,plb4", },
        { .compatible = "ibm,opb", },
        { .compatible = "ibm,ebc", },

Could of_platform_bus_probe() be simplified? No one uses the first and
third parameters.

-- 
Jon Smirl
jonsmirl@gmail.com