From: "Jon Smirl" <jonsmirl@gmail.com>
To: "Jochen Friedrich" <jochen@scram.de>
Cc: Scott Wood <scottwood@freescale.com>, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 4/5] Convert PowerPC MPC i2c to of_platform_driver from platform_driver
Date: Wed, 2 Jan 2008 14:49:57 -0500 [thread overview]
Message-ID: <9e4733910801021149h15abab7cr9d4f4d931b838114@mail.gmail.com> (raw)
In-Reply-To: <477BE8F8.9030804@scram.de>
On 1/2/08, Jochen Friedrich <jochen@scram.de> wrote:
>
> Should this go into some central file? Else we would have to copy it in any i2c bus driver that supports powerpc.
> This would at least be i2c-cpm and i2c-gpio.
I can change that in the next rev. I'm waiting to see if there are any
more changes.
> IMHO, there should be a node attribute to override i2c_adapter.class. Legacy i2c drivers (in particular v4l and dvb drivers) use this class to decide which adapter to bind to. dbox2 needs I2C_CLASS_TV_DIGITAL (4).
I hadn't paid any attention to i2c_adapter.class. Now that you mention
it I wonder why i2c has it. It appears to be a holdover from the
older mechanism of searching for devices and it is used as a filter to
reduce the number of device being searched. I would think a new style
driver could just ignore it.
It is probably best to fix it in a successive patch.
--
Jon Smirl
jonsmirl@gmail.com
next prev parent reply other threads:[~2008-01-02 19:49 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-20 4:41 [PATCH 0/5] Version 17, series to add device tree naming to i2c Jon Smirl
2007-12-20 4:41 ` [PATCH 1/5] Implement module aliasing for i2c to translate from device tree names Jon Smirl
2008-01-11 19:20 ` [i2c] " Jean Delvare
2008-01-12 8:46 ` Jean Delvare
2008-01-12 16:26 ` Jon Smirl
2008-01-13 14:41 ` Jean Delvare
2008-01-13 16:24 ` Jon Smirl
2008-01-13 17:40 ` Jean Delvare
2008-01-13 18:01 ` Jon Smirl
2008-01-13 18:45 ` Jean Delvare
2008-01-13 18:50 ` Jon Smirl
2008-01-13 19:05 ` Jean Delvare
2007-12-20 4:41 ` [PATCH 2/5] Modify several rtc drivers to use the alias names list property of i2c Jon Smirl
2007-12-20 4:41 ` [PATCH 3/5] Clean up error returns Jon Smirl
2007-12-20 4:41 ` [PATCH 4/5] Convert PowerPC MPC i2c to of_platform_driver from platform_driver Jon Smirl
2007-12-20 5:16 ` David Gibson
2007-12-20 6:01 ` Olof Johansson
2007-12-20 6:04 ` Stefan Roese
2007-12-20 15:56 ` Jon Smirl
2008-01-02 19:41 ` Jochen Friedrich
2008-01-02 19:49 ` Jon Smirl [this message]
2007-12-20 4:41 ` [PATCH 5/5] Convert pfc8563 i2c driver from old style to new style Jon Smirl
2007-12-20 23:59 ` [PATCH 0/5] Version 17, series to add device tree naming to i2c Jon Smirl
2007-12-27 16:47 ` Jon Smirl
2007-12-28 12:14 ` Jean Delvare
2008-01-10 14:14 ` Jon Smirl
2008-01-10 16:14 ` Jean Delvare
2008-01-11 8:56 ` [i2c] " Jean Delvare
2008-01-11 15:52 ` Jon Smirl
2008-01-11 16:05 ` Jochen Friedrich
2008-01-11 19:15 ` Jean Delvare
2008-01-11 20:16 ` Jon Smirl
2008-01-12 9:08 ` Jean Delvare
2008-01-12 16:00 ` Jon Smirl
2008-01-13 15:09 ` Jean Delvare
-- strict thread matches above, loose matches on Subject: below --
2007-12-10 18:33 [PATCH 0/5] Series " Jon Smirl
2007-12-10 18:33 ` [PATCH 4/5] Convert PowerPC MPC i2c to of_platform_driver from platform_driver Jon Smirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e4733910801021149h15abab7cr9d4f4d931b838114@mail.gmail.com \
--to=jonsmirl@gmail.com \
--cc=jochen@scram.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).