From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.179]) by ozlabs.org (Postfix) with ESMTP id EA5F1DDDFB for ; Wed, 23 Jan 2008 14:09:18 +1100 (EST) Received: by wa-out-1112.google.com with SMTP id m28so4876357wag.13 for ; Tue, 22 Jan 2008 19:09:17 -0800 (PST) Message-ID: <9e4733910801221909s49c171cdm880a7e2eaafb83b4@mail.gmail.com> Date: Tue, 22 Jan 2008 22:09:17 -0500 From: "Jon Smirl" To: "Grant Likely" Subject: Re: [PATCH 1/3] Rename i2c-mpc to i2c-mpc-drv in preparation for breaking out common code. In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <20080123020912.31675.48787.stgit@terra.home> <20080123134654.cb5e249d.sfr@canb.auug.org.au> <9e4733910801221850k406f0985jd072876b681299da@mail.gmail.com> Cc: Stephen Rothwell , i2c@lm-sensors.org, linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 1/22/08, Grant Likely wrote: > On 1/22/08, Jon Smirl wrote: > > On 1/22/08, Stephen Rothwell wrote: > > > Adding -M or -C to the "git diff" should identify renames and > > > makes this sort of patch much easier to review. > > > > I use stgit, I'll ask them how to generate rename patches. The actual > > git diff is buried inside stgit somewhere. > > From the "stg mail --help" output: > > -O DIFF_OPTS, --diff-opts=DIFF_OPTS > options to pass to git-diff I found that one, there doesn't appear to be a way to set it permanently via the config file. I asked them to add the option. Here's the patch with -M set, I'll make sure and set it on the final version. These patches apply on top of Jean's patch adding module loading to i2c, which apply on top of his 2.6.25 tree. Rename i2c-mpc to i2c-mpc-drv in preparation for breaking out common code. Signed-off-by: Jon Smirl --- drivers/i2c/busses/Makefile | 2 drivers/i2c/busses/i2c-mpc-drv.c | 421 ++++++++++++++++++++++++++++++++++++++ drivers/i2c/busses/i2c-mpc.c | 421 -------------------------------------- 3 files changed, 423 insertions(+), 421 deletions(-) create mode 100644 drivers/i2c/busses/i2c-mpc-drv.c delete mode 100644 drivers/i2c/busses/i2c-mpc.c diff --git a/drivers/i2c/busses/Makefile b/drivers/i2c/busses/Makefile index ea7068f..171800d 100644 --- a/drivers/i2c/busses/Makefile +++ b/drivers/i2c/busses/Makefile @@ -2,6 +2,8 @@ # Makefile for the i2c bus drivers. # +i2c-mpc-objs := i2c-mpc-drv.o + obj-$(CONFIG_I2C_ALI1535) += i2c-ali1535.o obj-$(CONFIG_I2C_ALI1563) += i2c-ali1563.o obj-$(CONFIG_I2C_ALI15X3) += i2c-ali15x3.o diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc-drv.c similarity index 100% rename from drivers/i2c/busses/i2c-mpc.c rename to drivers/i2c/busses/i2c-mpc-drv.c -- Jon Smirl jonsmirl@gmail.com