From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.176]) by ozlabs.org (Postfix) with ESMTP id 9B617DDF44 for ; Sat, 26 Jan 2008 11:35:38 +1100 (EST) Received: by wa-out-1112.google.com with SMTP id m28so1378203wag.13 for ; Fri, 25 Jan 2008 16:35:37 -0800 (PST) Message-ID: <9e4733910801250913k6e89daefy330324161169b0f1@mail.gmail.com> Date: Fri, 25 Jan 2008 12:13:09 -0500 From: "Jon Smirl" To: i2c@lm-sensors.org, linuxppc-dev@ozlabs.org Subject: Re: [i2c] [PATCH] mpc i2c driver, compare to NO_IRQ instead of zero In-Reply-To: <20080121200740.13800.20524.stgit@terra.home> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <20080121200740.13800.20524.stgit@terra.home> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Any final objections to this patch? When these were changed to 0 instead of NO_IRQ it should have broken polling mode on ppc. ppc would treat polling mode, NO_IRQ=-1, as an error. On powerpc this change is a NOP since NO_IRQ=0. On 1/21/08, Jon Smirl wrote: > Alter the mpc i2c driver to use the NO_IRQ symbol instead of the constant zero when checking for valid interrupts. NO_IRQ=-1 on ppc and NO_IRQ=0 on powerpc so the checks against zero are not correct. > > Signed-off-by: Jon Smirl > --- > > drivers/i2c/busses/i2c-mpc.c | 10 +++++----- > 1 files changed, 5 insertions(+), 5 deletions(-) > > > diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c > index bbe787b..d20959d 100644 > --- a/drivers/i2c/busses/i2c-mpc.c > +++ b/drivers/i2c/busses/i2c-mpc.c > @@ -99,7 +99,7 @@ static int i2c_wait(struct mpc_i2c *i2c, unsigned timeout, int writing) > u32 x; > int result = 0; > > - if (i2c->irq == 0) > + if (i2c->irq == NO_IRQ) > { > while (!(readb(i2c->base + MPC_I2C_SR) & CSR_MIF)) { > schedule(); > @@ -329,7 +329,7 @@ static int fsl_i2c_probe(struct platform_device *pdev) > return -ENOMEM; > > i2c->irq = platform_get_irq(pdev, 0); > - if (i2c->irq < 0) { > + if (i2c->irq < NO_IRQ) { > result = -ENXIO; > goto fail_get_irq; > } > @@ -344,7 +344,7 @@ static int fsl_i2c_probe(struct platform_device *pdev) > goto fail_map; > } > > - if (i2c->irq != 0) > + if (i2c->irq != NO_IRQ) > if ((result = request_irq(i2c->irq, mpc_i2c_isr, > IRQF_SHARED, "i2c-mpc", i2c)) < 0) { > printk(KERN_ERR > @@ -367,7 +367,7 @@ static int fsl_i2c_probe(struct platform_device *pdev) > return result; > > fail_add: > - if (i2c->irq != 0) > + if (i2c->irq != NO_IRQ) > free_irq(i2c->irq, i2c); > fail_irq: > iounmap(i2c->base); > @@ -384,7 +384,7 @@ static int fsl_i2c_remove(struct platform_device *pdev) > i2c_del_adapter(&i2c->adap); > platform_set_drvdata(pdev, NULL); > > - if (i2c->irq != 0) > + if (i2c->irq != NO_IRQ) > free_irq(i2c->irq, i2c); > > iounmap(i2c->base); > > > _______________________________________________ > i2c mailing list > i2c@lm-sensors.org > http://lists.lm-sensors.org/mailman/listinfo/i2c > -- Jon Smirl jonsmirl@gmail.com