Re: [PATCH] rtc-pcf8563: Add device ids table

From: "Jon Smirl" <jonsmirl@gmail.com>
To: "Jochen Friedrich" <jochen@scram.de>
Cc: Alessandro Zummo <alessandro.zummo@towertech.it>,
	rtc-linux@googlegroups.com,
	linuxppc-dev list <linuxppc-dev@ozlabs.org>,
	i2c@lm-sensors.org, Jean Delvare <khali@linux-fr.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] rtc-pcf8563: Add device ids table
Date: Wed, 23 Apr 2008 09:46:33 -0400	[thread overview]
Message-ID: <9e4733910804230646r2364ee0ct2c35549f6e6d1aaa@mail.gmail.com> (raw)
In-Reply-To: <480F390A.90707@scram.de>

On 4/23/08, Jochen Friedrich <jochen@scram.de> wrote:
> Hi Jean,
>
>
>  > Jochen, I'm a bit confused by the dependencies that exist - or not -
>  > between these 7 patches you sent at once. I thought they had to be
>  > applied in sequence but it seems not? And some of them should
>  > apparently go through me i2c tree but others (e.g. [7/7]) not?
>
>
> [1/7] and [2/7] are forward ports of patches from you. I'm currently
>  just running a make allmodconfig compile to check if it really caught
>  all affected i2c drivers.
>
>  These are the patches we are talking about.
>
>  [3/7] is the OF helper stuff which translates between OF names and
>  i2c types. It does NOT translate OF names to module names, but relies
>  on [1/7] to do so. Without [1/7], [3/7] still applies, but module
>  auto loading won't work.
>
>  This has been applied to 2.6.26.
>
>
>  > I would appreciate if you could summarize quickly which patches depend
>  > on others in which way. If we can make smaller subsets of patches, that
>  > will be easier for me to review and push upstream on my limited time.
>
>
> [4/7] is the patch from Jon Smirl to convert i2c-mpc to OF. This relies
>  on [3/7] instead of Jons initial OF-autoloading patches you didn't like.
>  As there were no comments at all, I would however postpone this to 2.6.27.

This is why we chose to ignore mainline and do these changes in our
own tree. There is no certainty when or if these patches will ever go
in. This has also caused us to stop submitting code in other areas.
It's all intertwined and too much work to break up.

>  [5/7] is the cleanup patch (originating from you) which completely removes
>  old driver matching scheme. This should probably wait until 2.6.27, as well.
>  This relies on [1/7] and [2/7].
>
>  [6/7] and [7/7] are a new driver and depend on [3/7]. This can wait for 2.6.27,
>  as well (i would rather like to see those in -mm to get more testing, though).
>
>  Thanks,
>
> Jochen
>
> _______________________________________________
>  Linuxppc-dev mailing list
>  Linuxppc-dev@ozlabs.org
>  https://ozlabs.org/mailman/listinfo/linuxppc-dev
>

-- 
Jon Smirl
jonsmirl@gmail.com