linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: "Jon Smirl" <jonsmirl@gmail.com>
To: "Grant Likely" <grant.likely@secretlab.ca>
Cc: liam.girdwood@wolfsonmicro.com, alsa-devel@alsa-project.org,
	broonie@opensource.wolfsonmicro.com, timur@freescale.com,
	linuxppc-dev@ozlabs.org
Subject: Re: [alsa-devel] [PATCH 2/3] ALSA SoC: Add mpc5200-psc I2S driver
Date: Mon, 7 Jul 2008 12:32:29 -0400	[thread overview]
Message-ID: <9e4733910807070932q108da172n117c0670238db8a5@mail.gmail.com> (raw)
In-Reply-To: <20080701235335.16923.43253.stgit@trillian.secretlab.ca>

On 7/1/08, Grant Likely <grant.likely@secretlab.ca> wrote:
> From: Grant Likely <grant.likely@secretlab.ca>
>
>  This is an I2S bus driver for the MPC5200 PSC device.  It is probably
>  will not be merged as-is because it uses v1 of the ASoC API, but I want
>  to get it out there for comments.
>  ---

I need some slight tweaks since we are using PSC1 in cellphone mode to
distribute the audio clock.

		i2s@2000 { /* PSC1 in i2s mode */
			compatible = "fsl,mpc5200b-psc-i2s","fsl,mpc5200-psc-i2s";
			cell-index = <0>;
			reg = <0x2000 0x100>;
			interrupts = <0x2 0x1 0x0>;
			interrupt-parent = <&mpc5200_pic>;
		};

		i2s@2200 { /* PSC2 in i2s mode */
			compatible = "fsl,mpc5200b-psc-i2s","fsl,mpc5200-psc-i2s";
			cell-index = <1>;
			reg = <0x2200 0x100>;
			interrupts = <0x2 0x2 0x0>;
			interrupt-parent = <&mpc5200_pic>;
			codec-handle = <&tas0>;
			fsl5200-cellslave;
		};

Our PSC1 is in master mode, but it doesn't have a codec hooked to it.
I needed to modify the driver to initialize the PSC to i2s master mode
but then not start all of the ALSA support. You can detect this state
since there is no codec node. Putting PSC1 into master mode lets us
get our external audio clock inside the mpc5200.

PSC2 is a cellphone slave. It gets its clock from PSC1. Everything is
the same as what you are doing except I need to set
MPC52xx_PSC_SICR_CELLSLAVE and MPC52xx_PSC_SICR_GENCLK when the
fsl5200-cellslave attribute is present.

We need to tie the two PSCs up like this to get the audio clock in via
PSC1 and then have PSC2 generate the frame clock when the i2s data is
transmitted.

Do you want a diff, or do you have a new version with DMA broken out?


-- 
Jon Smirl
jonsmirl@gmail.com

  parent reply	other threads:[~2008-07-07 16:32 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-01 23:53 [PATCH 1/3] ALSA SoC: Add OpenFirmware helper for matching bus and codec drivers Grant Likely
2008-07-01 23:53 ` [PATCH 2/3] ALSA SoC: Add mpc5200-psc I2S driver Grant Likely
2008-07-02 10:34   ` [alsa-devel] " Liam Girdwood
2008-07-02 13:51   ` Jon Smirl
2008-07-03 16:28     ` Grant Likely
2008-07-04 11:03       ` Timur Tabi
2008-07-04 14:41         ` Grant Likely
2008-07-05  1:28         ` David Gibson
2008-07-02 15:19   ` Jon Smirl
2008-07-03 16:30     ` Grant Likely
2008-07-06 17:56   ` Jon Smirl
2008-07-07 10:59     ` Mark Brown
2008-07-07 13:23       ` Jon Smirl
2008-07-12  6:26         ` Grant Likely
2008-07-07 16:32   ` Jon Smirl [this message]
2008-07-12  6:30     ` Grant Likely
2008-07-09  8:22   ` new to sound world
2008-07-01 23:53 ` [PATCH 3/3] ALSA SoC: Add Texas Instruments TLV320AIC26 codec driver Grant Likely
2008-07-02 10:48   ` [alsa-devel] " Liam Girdwood
2008-07-12  6:00     ` Grant Likely
2008-07-12 17:36       ` Mark Brown
2008-07-12 18:13         ` Grant Likely
2008-07-17 23:31         ` Grant Likely
2008-07-18  9:58           ` Mark Brown
2008-07-18 16:14             ` Grant Likely
2008-07-02 13:52   ` Jon Smirl
2008-07-02 16:08     ` Liam Girdwood
2008-07-04 20:49   ` Mark Brown
2008-07-04 23:44     ` Grant Likely
2008-07-02  9:50 ` [alsa-devel] [PATCH 1/3] ALSA SoC: Add OpenFirmware helper for matching bus and codec drivers Takashi Iwai
2008-07-02 15:48   ` Grant Likely
2008-07-02 15:57     ` Liam Girdwood
2008-07-02 13:50 ` Jon Smirl
2008-07-02 15:27 ` Jon Smirl
2008-07-03 16:33   ` Grant Likely
2008-07-04 11:05     ` Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e4733910807070932q108da172n117c0670238db8a5@mail.gmail.com \
    --to=jonsmirl@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=grant.likely@secretlab.ca \
    --cc=liam.girdwood@wolfsonmicro.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=timur@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).