linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: "Jon Smirl" <jonsmirl@gmail.com>
To: "Grant Likely" <grant.likely@secretlab.ca>
Cc: linux-ppc list <linuxppc-dev@ozlabs.org>,
	Andre Schwarz <andre.schwarz@matrix-vision.de>,
	David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH] Add MPC5200B base board mvBC-P
Date: Mon, 7 Jul 2008 14:51:28 -0400	[thread overview]
Message-ID: <9e4733910807071151m8cac0fob63f9663457da2f1@mail.gmail.com> (raw)
In-Reply-To: <fa686aa40807070712x77ff7aben4cf51731bb4f5985@mail.gmail.com>

On 7/7/08, Grant Likely <grant.likely@secretlab.ca> wrote:
> On Mon, Jul 7, 2008 at 1:49 AM, Andre Schwarz
>  <andre.schwarz@matrix-vision.de> wrote:
>  > David,
>  >
>  > thanks - removed "device_type" from the DMA controller.
>  >
>  > Which nodes actually require "device_type" and which don't ?
>  >
>  > Is there some general rule ?
>
>
> Segher, David;
>
>  In OF, what is the purpose of device_type?  From what I understand
>  right now, each value of device_type claims a software interface that
>  the device supports.  So for example, device_type = "serial" means
>  that firmware supports using the device as a serial port, correct?
>  So, similarly, if OF did not have a driver for the device, then the
>  presence a device_type property would be a bug, right?
>
>  Does device_type indicated any other information other than firmware
>  driver interface?
>
>  I had an epiphany about device_type this weekend (and by epiphany, I
>  mean realizing my own stupidity).  If I'm correct about the above
>  questions, then that would mean it is *always* a bug to have a
>  device_type property in .dts file because there is no firmware
>  interface.  So, it seems to me that we shouldn't just be eliminating
>  undefined device_type values, but also eliminate the ones that are
>  defined in OF because .dts users do not support the firmware driver
>  interface.
>
>  Am I correct?
>
>  The only situation where I can see it being appropriate to specify
>  device_type is to work around older bindings that are ambiguous with
>  their other properties.

I experimented with this on my own trees.
			device_type = "serial";
Is current required on the boot console or it will disappear.


-- 
Jon Smirl
jonsmirl@gmail.com

  reply	other threads:[~2008-07-07 18:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-04 16:35 [PATCH] Add MPC5200B base board mvBC-P Andre Schwarz
2008-07-04 17:00 ` Grant Likely
2008-07-04 17:27   ` Jon Smirl
2008-07-05  9:32   ` André Schwarz
2008-07-05 16:13     ` Grant Likely
2008-07-06 23:50 ` David Gibson
2008-07-07  7:49   ` Andre Schwarz
2008-07-07 14:12     ` Grant Likely
2008-07-07 18:51       ` Jon Smirl [this message]
2008-07-08  3:41       ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e4733910807071151m8cac0fob63f9663457da2f1@mail.gmail.com \
    --to=jonsmirl@gmail.com \
    --cc=andre.schwarz@matrix-vision.de \
    --cc=david@gibson.dropbear.id.au \
    --cc=grant.likely@secretlab.ca \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).